From: Alistair Francis <alistair23@gmail.com>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: figlesia@xilinx.com, "Peter Maydell" <peter.maydell@linaro.org>,
"Edgar Iglesias" <edgar.iglesias@xilinx.com>,
"Sai Pavan Boddu" <sai.pavan.boddu@xilinx.com>,
"Francisco Iglesias" <frasse.iglesias@gmail.com>,
"Alistair Francis" <alistair@alistair23.me>,
"Richard Henderson" <richard.henderson@linaro.org>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
"KONRAD Frederic" <frederic.konrad@adacore.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Luc Michel" <luc.michel@greensocs.com>
Subject: Re: [PATCH v1 3/3] target/microblaze: Plug temp leak around eval_cond_jmp()
Date: Wed, 6 Nov 2019 13:57:59 -0800 [thread overview]
Message-ID: <CAKmqyKM5kyRJ+A8BO-5-71mxm64vYP7HvyD7tDe+cJu-L8_xDQ@mail.gmail.com> (raw)
In-Reply-To: <20191106141424.27244-4-edgar.iglesias@gmail.com>
On Wed, Nov 6, 2019 at 6:17 AM Edgar E. Iglesias
<edgar.iglesias@gmail.com> wrote:
>
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> Plug temp leak around eval_cond_jmp().
>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/microblaze/translate.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
> index e9ff9e650d..93e22a89ac 100644
> --- a/target/microblaze/translate.c
> +++ b/target/microblaze/translate.c
> @@ -1705,7 +1705,10 @@ void gen_intermediate_code(CPUState *cs, TranslationBlock *tb, int max_insns)
> dc->tb_flags &= ~D_FLAG;
> /* If it is a direct jump, try direct chaining. */
> if (dc->jmp == JMP_INDIRECT) {
> - eval_cond_jmp(dc, env_btarget, tcg_const_i64(dc->pc));
> + TCGv_i64 tmp_pc = tcg_const_i64(dc->pc);
> + eval_cond_jmp(dc, env_btarget, tmp_pc);
> + tcg_temp_free_i64(tmp_pc);
> +
> dc->is_jmp = DISAS_JUMP;
> } else if (dc->jmp == JMP_DIRECT) {
> t_sync_flags(dc);
> --
> 2.20.1
>
>
next prev parent reply other threads:[~2019-11-06 22:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 14:14 [PATCH v1 0/3] target/microblaze: Plug tcg temp leaks Edgar E. Iglesias
2019-11-06 14:14 ` [PATCH v1 1/3] target/microblaze: Plug temp leaks for loads/stores Edgar E. Iglesias
2019-11-06 14:32 ` Philippe Mathieu-Daudé
2019-11-06 14:37 ` Luc Michel
2019-11-06 21:55 ` Alistair Francis
2019-11-07 14:19 ` Richard Henderson
2019-11-08 12:36 ` Edgar E. Iglesias
2019-11-06 14:14 ` [PATCH v1 2/3] target/microblaze: Plug temp leaks with delay slot setup Edgar E. Iglesias
2019-11-06 14:33 ` Philippe Mathieu-Daudé
2019-11-06 14:41 ` Luc Michel
2019-11-06 21:56 ` Alistair Francis
2019-11-07 14:21 ` Richard Henderson
2019-11-06 14:14 ` [PATCH v1 3/3] target/microblaze: Plug temp leak around eval_cond_jmp() Edgar E. Iglesias
2019-11-06 14:32 ` Philippe Mathieu-Daudé
2019-11-06 14:42 ` Luc Michel
2019-11-06 21:57 ` Alistair Francis [this message]
2019-11-07 14:22 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKM5kyRJ+A8BO-5-71mxm64vYP7HvyD7tDe+cJu-L8_xDQ@mail.gmail.com \
--to=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=figlesia@xilinx.com \
--cc=frasse.iglesias@gmail.com \
--cc=frederic.konrad@adacore.com \
--cc=luc.michel@greensocs.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sai.pavan.boddu@xilinx.com \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).