From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85DB8C76196 for ; Fri, 19 Jul 2019 16:21:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5653E2184E for ; Fri, 19 Jul 2019 16:21:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s0dbBfiy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5653E2184E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoVdI-0000xf-Ex for qemu-devel@archiver.kernel.org; Fri, 19 Jul 2019 12:21:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41599) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoVd6-0000UU-HJ for qemu-devel@nongnu.org; Fri, 19 Jul 2019 12:21:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hoVcs-0006M7-R3 for qemu-devel@nongnu.org; Fri, 19 Jul 2019 12:21:00 -0400 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]:35451) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hoVcp-0005lb-Mr; Fri, 19 Jul 2019 12:20:52 -0400 Received: by mail-lj1-x235.google.com with SMTP id x25so31364749ljh.2; Fri, 19 Jul 2019 09:19:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fFo+CuEPeHwBPOBeb8KPru+ObIIM6iFnpGufu0nSdZU=; b=s0dbBfiylTYR8n2kcx9hjS7Smb4V0pqNmjI+SvjPlqyDK6eSOqmPP7q+RJfTJS3S38 bfD9V2lOLaDeuoJm4/FuFnsCJMAu7odEniUrH+BKSe6zjN3WnAOpM5XWHJTy6XxHzPpL 5Qz/5wOwW1uX19H0GhuvkuEnekTsMi78mDGZY5+k4UPRtQLbt8OnlBifxq2BPllQ0eAs e5rASm62zuuoW5o5H0WRY+uoDOiFXlYs03rBkUJslDcHWoUo13MKFBbP+6At8LrNjqcb x5Bu49fFjGNOq+7wHCEvEkyj/0uNqsfC0rR2S4JMO9E7DtxSg5nF8Gb+3HZsN60Al0he srrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fFo+CuEPeHwBPOBeb8KPru+ObIIM6iFnpGufu0nSdZU=; b=i14gMqHGcoHwu2xa9IjEbinsT0PPFVwgC9vGpdVFGW/hLhk2jspvYCnbU/uFUPFY3+ AJNuwLWpFNg/hRCILhzbWi2SiUZBCsE+SSq73NWSDn8mDgLPJgfVTp3Lo+9KTgh8z6P/ ez8LtSxqtySFST8LwGInM8W5MLu6WZUQ5XUY4iTWx+JPG7bShCNj+0ty7KG9qreuB+l1 InQBZRfCFK/4KAavyntu80t1608UlVty/L5OBpORradQzhyZhaXfEwVfBlCIIsnvyptV +2QH1yvg7CQkiSUre36ZpHa+5sWaRxIvvCXnoU8GWfs0qTEzrOO2PBsaDay9y8cthykl kxOg== X-Gm-Message-State: APjAAAWnaDp2w4k89DUUHJf6m8QjWN43Q9Cc0KcBW/y+6yyajq9NGB98 TyopM5/hv69rzpghFSn7J9q2Xcb9rrIIYozv/tU= X-Google-Smtp-Source: APXvYqz5vJecAc5SBh2jhX+5BLONEwHwYP8EQgGgh9KUSN/yA3QLgL2ukpA8MjdYY5927Z4Tvfoscpb46L2DkNgOfug= X-Received: by 2002:a2e:b4c9:: with SMTP id r9mr28051885ljm.196.1563553177618; Fri, 19 Jul 2019 09:19:37 -0700 (PDT) MIME-Version: 1.0 References: <20190719015811.14776-1-palmer@sifive.com> In-Reply-To: From: Alistair Francis Date: Fri, 19 Jul 2019 09:16:15 -0700 Message-ID: To: Peter Maydell Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::235 Subject: Re: [Qemu-devel] [PULL] RISC-V Patches for 4.2-rc2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Palmer Dabbelt , "open list:RISC-V" , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jul 19, 2019 at 4:11 AM Peter Maydell wrote: > > On Fri, 19 Jul 2019 at 12:03, Peter Maydell wrote: > > This passes the 'make check' tests but it prints out a lot > > of warnings as it does so: > > > > qemu-system-riscv64: warning: No -bios option specified. Not loading a firmware. > > qemu-system-riscv64: warning: This default will change in QEMU 4.3. > > Please use the -bios option to aviod breakages when this happens. > > qemu-system-riscv64: warning: See QEMU's deprecation documentation for details > > > > (repeated 7 or 8 times during the course of a test run) > > > > Can we make the tests not trigger warnings, please? > > (I have a filter where I search through for strings like > > "warning" because warnings that shouldn't happen often don't > > actually cause the tests to fail.) > > Forgot to mention, but a common way to do this is to say > "don't print the warnings about bios image loading if > qtest_enabled(), because with qtest we never execute any > guest code anyway". That will probably fix the warnings here. Testing my patch now, I'll send it out today. > > > Also, I notice that you have a typo: "aviod" should be "avoid". Fixed. > > Also also, the warning message mentions "QEMU 4.3", but our > versioning system bumps the major version every year, so > the pending release is 4.1, the next one will be 4.2, and > then the release after that will be 5.0 because it will be the > first release in 2020. I just dropped the version number in the warning message. Alistair > > (Plus, your merge commit message says this pullreq is > for 4.2-rc2, which is a typo for 4.1-rc2 I assume.) > > Since this pullreq does pass the tests, and rc2 is not far off > now (Tuesday), I think my suggestion is that I'll apply this > as-is, and we should fix up the issues with the warning messages > as a followup patch. I think that's better than holding this > out of master and making it risk missing rc2. > > thanks > -- PMM