From: Alistair Francis <alistair23@gmail.com>
To: Robbin Ehn <rehn@rivosinc.com>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Subject: Re: [PATCH] linux-user/riscv: Add new extensions to hwprobe
Date: Fri, 1 Sep 2023 12:27:21 +1000 [thread overview]
Message-ID: <CAKmqyKPmhAUHe5nN=V05TwvWZkuQhRFrigB-FRkBgRb=zJPQWQ@mail.gmail.com> (raw)
In-Reply-To: <bc82203b72d7efb30f1b4a8f9eb3d94699799dc8.camel@rivosinc.com>
On Tue, Aug 29, 2023 at 12:58 AM Robbin Ehn <rehn@rivosinc.com> wrote:
>
> This patch adds the new extensions in
> linux 6.5 to the hwprobe syscall.
>
> And fixes RVC check to OR with correct value.
> The previous variable contains 0 therefore it
> did work.
>
> Signed-off-by: Robbin Ehn <rehn@rivosinc.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> linux-user/syscall.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 9353268cc1..c46a0b1493 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -9049,6 +9049,10 @@ static int do_getdents64(abi_long dirfd, abi_long arg2, abi_long count)
> #define RISCV_HWPROBE_KEY_IMA_EXT_0 4
> #define RISCV_HWPROBE_IMA_FD (1 << 0)
> #define RISCV_HWPROBE_IMA_C (1 << 1)
> +#define RISCV_HWPROBE_IMA_V (1 << 2)
> +#define RISCV_HWPROBE_EXT_ZBA (1 << 3)
> +#define RISCV_HWPROBE_EXT_ZBB (1 << 4)
> +#define RISCV_HWPROBE_EXT_ZBS (1 << 5)
>
> #define RISCV_HWPROBE_KEY_CPUPERF_0 5
> #define RISCV_HWPROBE_MISALIGNED_UNKNOWN (0 << 0)
> @@ -9096,7 +9100,15 @@ static void risc_hwprobe_fill_pairs(CPURISCVState *env,
> riscv_has_ext(env, RVD) ?
> RISCV_HWPROBE_IMA_FD : 0;
> value |= riscv_has_ext(env, RVC) ?
> - RISCV_HWPROBE_IMA_C : pair->value;
> + RISCV_HWPROBE_IMA_C : 0;
> + value |= riscv_has_ext(env, RVV) ?
> + RISCV_HWPROBE_IMA_V : 0;
> + value |= cfg->ext_zba ?
> + RISCV_HWPROBE_EXT_ZBA : 0;
> + value |= cfg->ext_zbb ?
> + RISCV_HWPROBE_EXT_ZBB : 0;
> + value |= cfg->ext_zbs ?
> + RISCV_HWPROBE_EXT_ZBS : 0;
> __put_user(value, &pair->value);
> break;
> case RISCV_HWPROBE_KEY_CPUPERF_0:
> --
> 2.39.2
>
>
next prev parent reply other threads:[~2023-09-01 2:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 14:56 [PATCH] linux-user/riscv: Add new extensions to hwprobe Robbin Ehn
2023-08-28 15:54 ` Richard Henderson
2023-09-01 2:27 ` Alistair Francis [this message]
2023-09-01 2:28 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKmqyKPmhAUHe5nN=V05TwvWZkuQhRFrigB-FRkBgRb=zJPQWQ@mail.gmail.com' \
--to=alistair23@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=rehn@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).