From: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: David Gibson <david@gibson.dropbear.id.au>,
Richard Henderson <richard.henderson@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Howard Spoelstra <hsp.cat7@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v4 0/7] tcg/ppc: Add vector opcodes
Date: Tue, 25 Jun 2019 20:01:39 +0200 [thread overview]
Message-ID: <CAL1e-=gupur20rK79TSqAZ1NwavDSvL+QcwzF4idg=+of_b0Hg@mail.gmail.com> (raw)
In-Reply-To: <b8aab3f4-e3eb-a137-62b4-ba5ac1a2ad8f@ilande.co.uk>
On Jun 25, 2019 5:42 PM, "Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>
wrote:
>
> The problem is that in tcg/tcg-op.h we define "DEF(dup2_vec, 1, 2, 0,
IMPLVEC |
> IMPL(TCG_TARGET_REG_BITS == 32))" and in the last patchset dup2_vec isn't
introduced
> until towards the end. Unfortunately it's not a simple as bringing the
patch forward
> within the series to maintain bisectability because the current
implementation
> depends on VMRG which only appears in the patch just before it...
>
My strong impression is that VMRG, VSPLT, VSLDOI, ... opcodes and basic
logic could have been defined very early in the series. (They all just
support other TCG vector operations. Their functionalty just helps achieve
other, exposed, backend functionalities.) That would reduce patch
dependencies and allow “patch mobility” within the rest of the series.
However, I am not positive at all that would solve the problem at hand.
Aleksandar
next prev parent reply other threads:[~2019-06-25 18:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-19 4:15 [Qemu-devel] [PATCH v4 0/7] tcg/ppc: Add vector opcodes Richard Henderson
2019-05-19 4:15 ` [Qemu-devel] [PATCH v4 1/7] tcg/ppc: Initial backend support for Altivec Richard Henderson
2019-05-19 4:15 ` [Qemu-devel] [PATCH v4 2/7] tcg/ppc: Support vector shift by immediate Richard Henderson
2019-05-19 4:15 ` [Qemu-devel] [PATCH v4 3/7] tcg/ppc: Support vector multiply Richard Henderson
2019-05-19 5:05 ` Aleksandar Markovic
2019-05-19 14:45 ` Richard Henderson
2019-05-19 4:15 ` [Qemu-devel] [PATCH v4 4/7] tcg/ppc: Support vector dup2 Richard Henderson
2019-05-19 4:15 ` [Qemu-devel] [PATCH v4 5/7] tcg/ppc: Update vector support to v2.06 Richard Henderson
2019-05-19 4:15 ` [Qemu-devel] [PATCH v4 6/7] tcg/ppc: Update vector support to v2.07 Richard Henderson
2019-05-19 4:15 ` [Qemu-devel] [PATCH v4 7/7] tcg/ppc: Update vector support to v3.00 Richard Henderson
2019-06-18 5:00 ` [Qemu-devel] [PATCH v4 0/7] tcg/ppc: Add vector opcodes Richard Henderson
2019-06-19 5:07 ` Mark Cave-Ayland
2019-06-20 11:51 ` Howard Spoelstra
2019-06-22 14:20 ` Mark Cave-Ayland
2019-06-22 15:01 ` Mark Cave-Ayland
2019-06-23 17:10 ` Aleksandar Markovic
2019-06-25 6:56 ` Richard Henderson
2019-06-25 15:37 ` Mark Cave-Ayland
2019-06-25 15:56 ` Richard Henderson
2019-06-25 17:55 ` Mark Cave-Ayland
2019-06-26 7:45 ` Richard Henderson
2019-06-26 17:00 ` Mark Cave-Ayland
2019-06-26 18:18 ` BALATON Zoltan
2019-06-26 18:42 ` Richard Henderson
2019-06-26 19:38 ` Mark Cave-Ayland
2019-06-26 20:21 ` BALATON Zoltan
2019-06-27 17:24 ` Mark Cave-Ayland
2019-06-27 17:51 ` Richard Henderson
2019-06-27 17:54 ` Richard Henderson
2019-06-27 18:21 ` Mark Cave-Ayland
2019-06-26 8:33 ` David Gibson
2019-06-26 15:25 ` Richard Henderson
2019-06-25 18:01 ` Aleksandar Markovic [this message]
2019-06-19 8:11 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL1e-=gupur20rK79TSqAZ1NwavDSvL+QcwzF4idg=+of_b0Hg@mail.gmail.com' \
--to=aleksandar.m.mail@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=hsp.cat7@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).