From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: Yongji Xie <elohimes@gmail.com>
Cc: Xie Yongji <xieyongji@baidu.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2] libvhost-user: Zero memory allocated for VuVirtqInflightDesc
Date: Tue, 19 Nov 2019 11:59:07 +0400 [thread overview]
Message-ID: <CAMxuvaykbk-B+feVuU1rVpHK9GeZqjjongOF0YCLXbsrSRsYcw@mail.gmail.com> (raw)
In-Reply-To: <20191119075759.4334-1-xieyongji@baidu.com>
On Tue, Nov 19, 2019 at 11:58 AM <elohimes@gmail.com> wrote:
>
> From: Xie Yongji <xieyongji@baidu.com>
>
> Use a zero-initialized VuVirtqInflightDesc struct to avoid
> that scan-build reports that vq->resubmit_list[0].counter may
> be garbage value in vu_check_queue_inflights().
>
> Fixes: 5f9ff1eff ("libvhost-user: Support tracking inflight I/O in
> shared memory")
> Reported-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Signed-off-by: Xie Yongji <xieyongji@baidu.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> contrib/libvhost-user/libvhost-user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c
> index 68c27136ae..ec27b78ff1 100644
> --- a/contrib/libvhost-user/libvhost-user.c
> +++ b/contrib/libvhost-user/libvhost-user.c
> @@ -992,7 +992,7 @@ vu_check_queue_inflights(VuDev *dev, VuVirtq *vq)
> vq->shadow_avail_idx = vq->last_avail_idx = vq->inuse + vq->used_idx;
>
> if (vq->inuse) {
> - vq->resubmit_list = malloc(sizeof(VuVirtqInflightDesc) * vq->inuse);
> + vq->resubmit_list = calloc(vq->inuse, sizeof(VuVirtqInflightDesc));
> if (!vq->resubmit_list) {
> return -1;
> }
> --
> 2.17.1
>
prev parent reply other threads:[~2019-11-19 8:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 7:57 [PATCH v2] libvhost-user: Zero memory allocated for VuVirtqInflightDesc elohimes
2019-11-19 7:59 ` Marc-André Lureau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMxuvaykbk-B+feVuU1rVpHK9GeZqjjongOF0YCLXbsrSRsYcw@mail.gmail.com \
--to=marcandre.lureau@redhat.com \
--cc=elohimes@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xieyongji@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).