From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Juan Quintela <quintela@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified
Date: Mon, 19 Apr 2021 12:28:04 -0400 [thread overview]
Message-ID: <CAOpTY_oCNcPjB6aHn6kp6Pb=TJSYKLuTOWyLD+1LP24w3F_c=A@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA-u0XDFBuTaw2AcoP1NLSYNCSAEutXi+gfhb-qU=_UBGg@mail.gmail.com>
On Sun, Apr 18, 2021 at 11:54 AM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Thu, 15 Apr 2021 at 16:46, Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
> > When a migration blocker is added nothing is reported to the user,
> > inability to migrate such guest may come as a late surprise. As a bare
> > minimum, we can print a warning. To not pollute the output for those, who
> > have no intention to migrate their guests, introduce '--no-migration'
> > option which both block the migration and eliminates warning from
>
> I'm not a fan. For a lot of people and configurations this
> is going to be "add an extra complaint from QEMU to a previously
> working configuration". We add too many of those already.
I agree that warning with machine types that never supported live
migration would be useless noise, but warning if using an explicit
versioned machine type sounds like a reasonable default (as long as
the warnings includes clear instructions on how to silence them).
--
Eduardo
next prev parent reply other threads:[~2021-04-19 16:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 15:44 [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified Vitaly Kuznetsov
2021-04-15 16:04 ` Daniel P. Berrangé
2021-04-15 16:30 ` Eduardo Habkost
2021-04-15 16:40 ` Daniel P. Berrangé
2021-04-15 17:07 ` Daniel P. Berrangé
2021-04-15 17:28 ` Dr. David Alan Gilbert
2021-04-16 7:33 ` Vitaly Kuznetsov
2021-04-16 16:28 ` Eduardo Habkost
2021-04-17 9:33 ` Markus Armbruster
2021-04-19 16:42 ` Daniel P. Berrangé
2021-04-19 16:48 ` Eduardo Habkost
2021-04-19 17:11 ` Dr. David Alan Gilbert
2021-04-19 17:15 ` Daniel P. Berrangé
2021-04-19 17:17 ` Daniel P. Berrangé
2021-04-19 18:47 ` Dr. David Alan Gilbert
2021-04-19 19:32 ` Eduardo Habkost
2021-04-20 11:51 ` Dr. David Alan Gilbert
2021-04-20 13:48 ` Eduardo Habkost
2021-04-20 14:10 ` Dr. David Alan Gilbert
2021-04-20 14:15 ` Daniel P. Berrangé
2021-04-20 15:20 ` Eduardo Habkost
2021-04-17 9:35 ` Markus Armbruster
2021-04-19 7:26 ` Markus Armbruster
2021-04-19 15:46 ` Markus Armbruster
2021-04-18 15:53 ` Peter Maydell
2021-04-19 16:28 ` Eduardo Habkost [this message]
2021-04-19 16:37 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOpTY_oCNcPjB6aHn6kp6Pb=TJSYKLuTOWyLD+1LP24w3F_c=A@mail.gmail.com' \
--to=ehabkost@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).