Re: [Qemu-devel] [PATCH 0/6] net/eth: Remove duplicated tcp/udp_hdr structures

From: Dmitry Fleytman <dmitry.fleytman@gmail.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Zhang Chen <chen.zhang@intel.com>,
	Jason Wang <jasowang@redhat.com>,
	qemu-devel@nongnu.org, Li Zhijian <lizhijian@cn.fujitsu.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/6] net/eth: Remove duplicated tcp/udp_hdr structures
Date: Mon, 12 Aug 2019 11:21:04 +0300	[thread overview]
Message-ID: <EFCF7A78-EB8F-4492-89D2-6B36FB30B3A7@gmail.com> (raw)
In-Reply-To: <20190808143457.14111-1-philmd@redhat.com>

Reviewed-by: Dmitry Fleytman <dmitry.fleytman@gmail.com>

> On 8 Aug 2019, at 17:34, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> 
> This is a preparatory cleanup series.
> 
> Commit 75020a70215 introduced 4 very equivalent structures:
> - tcp_header and tcp_hdr,
> - udp_header and udp_hdr.
> 
> Choose the most widely use in the codebase, which happens to
> provide convenient bitfields manipulation macros and is not
> endian-specific.
> 
> Philippe Mathieu-Daudé (6):
>  hw/net/virtio-net: Use TCP_HEADER_FLAGS/TCP_HEADER_DATA_OFFSET macros
>  net/colo-compare: Use the tcp_header structure
>  net/filter-rewriter: Use the tcp_header structure
>  hw/net/vmxnet3: Use the tcp_header structure
>  net/eth: Remove the unused tcp_hdr structure
>  net/eth: Remove the single use of udp_hdr structure
> 
> hw/net/net_rx_pkt.c   |  2 +-
> hw/net/net_tx_pkt.c   |  9 +++++----
> hw/net/virtio-net.c   |  9 ++-------
> include/net/eth.h     | 47 ++++++++-----------------------------------
> net/colo-compare.c    | 14 ++++++-------
> net/filter-rewriter.c | 37 +++++++++++++++++++---------------
> 6 files changed, 44 insertions(+), 74 deletions(-)
> 
> -- 
> 2.20.1
>