From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com,
kwolf@redhat.com.com, dgilbert@redhat.com
Subject: Re: [PATCH] block: Remove monitor command block_passwd
Date: Tue, 23 Mar 2021 10:30:48 +0000 [thread overview]
Message-ID: <YFnDWNLTBEZWEIdk@redhat.com> (raw)
In-Reply-To: <20210323101951.3686029-1-armbru@redhat.com>
On Tue, Mar 23, 2021 at 11:19:51AM +0100, Markus Armbruster wrote:
> Command block_passwd always fails since
>
> Commit c01c214b69 "block: remove all encryption handling APIs"
> (v2.10.0) turned block_passwd into a stub that always fails, and
> hardcoded encryption_key_missing to false in query-named-block-nodes
> and query-block.
>
> Commit ad1324e044 "block: remove 'encryption_key_missing' flag from
> QAPI" just landed. Complete the cleanup job: remove block_passwd.
Oh, we never marked block_passwd as deprecated, so I missed this
cleanup.
None the less we're fine removing it, since anyone who has tried
to use it since 2.10 will have found it useless, and have been
unable to start their VMs with encrypted disks.
>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> This is based on my "[PATCH 00/28] qapi: Enforce naming rules". To
> apply directly, simply drop the qapi/pragma.json hunk.
>
> Based-on: <20210323094025.3569441-1-armbru@redhat.com>
>
>
> qapi/block-core.json | 14 --------------
> qapi/pragma.json | 1 -
> block/monitor/block-hmp-cmds.c | 10 ----------
> blockdev.c | 8 --------
> hmp-commands.hx | 15 ---------------
> 5 files changed, 48 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2021-03-23 10:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 10:19 [PATCH] block: Remove monitor command block_passwd Markus Armbruster
2021-03-23 10:30 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFnDWNLTBEZWEIdk@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kwolf@redhat.com.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).