On Apr  7 08:03, Peter Maydell wrote:
>On Wed, 7 Apr 2021 at 06:51, Klaus Jensen <its@irrelevant.dk> wrote:
>>
>> From: Klaus Jensen <k.jensen@samsung.com>
>>
>> Hi Peter,
>>
>> My apologies that these didn't make it for -rc2!
>>
>> I botched v1, so please pull this v2 instead.
>>
>>
>> The following changes since commit d0d3dd401b70168a353450e031727affee828527:
>>
>>   Update version for v6.0.0-rc2 release (2021-04-06 18:34:34 +0100)
>>
>> are available in the Git repository at:
>>
>>   git://git.infradead.org/qemu-nvme.git tags/nvme-fixes-2021-04-07-pull-request
>>
>> for you to fetch changes up to 5dd79300df47f07d0e9d6a7bda43b23ff26001dc:
>>
>>   hw/block/nvme: fix out-of-bounds read in nvme_subsys_ctrl (2021-04-07 07:27:09 +0200)
>>
>> ----------------------------------------------------------------
>> emulated nvme fixes for -rc3
>>
>> v2:
>>   - added missing patches
>>
>> ----------------------------------------------------------------
>
>Hi; this semes to generate a bunch of new warnings during 'make check'
>(not sure exactly which test is producing these, due to the usual
>interleaving when using -j8):
>
>qemu-system-i386: -device nvme,addr=04.0,drive=drv0,serial=foo:
>warning: drive property is deprecated; please use an nvme-ns device
>instead
>qemu-system-i386: -device
>nvme,addr=04.0,drive=drv0,serial=foo,cmb_size_mb=2: warning: drive
>property is deprecated; please use an nvme-ns device instead
>qemu-system-ppc64: -device nvme,addr=04.0,drive=drv0,serial=foo:
>warning: drive property is deprecated; please use an nvme-ns device
>instead
>qemu-system-ppc64: -device
>nvme,addr=04.0,drive=drv0,serial=foo,cmb_size_mb=2: warning: drive
>property is deprecated; please use an nvme-ns device instead
>qemu-system-x86_64: -device nvme,addr=04.0,drive=drv0,serial=foo:
>warning: drive property is deprecated; please use an nvme-ns device
>instead
>qemu-system-x86_64: -device
>nvme,addr=04.0,drive=drv0,serial=foo,cmb_size_mb=2: warning: drive
>property is deprecated; please use an nvme-ns device instead
>
>thanks
>-- PMM
>

Hi Peter,

tests/qtest/nvme-test.c is generating these warnings.

We didn't deprecate this formally, so I will remove the warning for now. 
The device works just fine with both "legacy" and "new-style" nvme-ns 
namespace definitions.

I'll do a v3.