From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F3DDC433ED for ; Tue, 20 Apr 2021 07:19:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55EDB61154 for ; Tue, 20 Apr 2021 07:19:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55EDB61154 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYkfm-0008R8-UK for qemu-devel@archiver.kernel.org; Tue, 20 Apr 2021 03:19:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYkcb-0007qK-6o; Tue, 20 Apr 2021 03:16:33 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:44883) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYkcZ-0000d8-0x; Tue, 20 Apr 2021 03:16:32 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 652381FF1; Tue, 20 Apr 2021 03:16:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 20 Apr 2021 03:16:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=8fwTo7vvRUSSZKluh7mOwAVqbG6 ePTzEYsu/BJ6mue4=; b=x3bOpL3TEXCe4JgtvHV+ML4KnHEPspzDgxaeTswvKfm 7Nrf4Usic7N3W8vphMN3RZadUrzWdK38T460vnbp+OcZeoXNxsVJzSgqyiUXwG/k TTpjvR34K69HSju8SXQrhOYDBnNidSczyKTsuEpE7KyvcsRPzuTiTKAEDMjY4FY3 bwrVLjJpL7M7T6/UetMSWztE657uROE2NjqpPlTVoV4OukEntqMnEPaM/wR9YsvL naLhjWWu+aSGXHAC++aEaap0yLlXMNC1dt61RSEd5xEwwrgdt4CdL5n49uLTHUst s7ZVB3GzXGSVAuRu49a7a17jc4BzD8E4YR3Zxbgb6cA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=8fwTo7 vvRUSSZKluh7mOwAVqbG6ePTzEYsu/BJ6mue4=; b=ATyCqshzJ1u9A9kB97rlM6 +g9mnyVZDJIG+v5gmOx7QdO3er/vpETG2aSoXvwdvm2u5C8xc81nrFgwZZkC7IYC 4ZzqJZRUG+G6WOXUIeBF52pxUXpMX+CmRefyUkPu5UEgb+spdKOvbpi+5tl3rj1o 4644SA8oLVmOtjgchHf5isVMMYwnD8fov2VIpwtOZqC4uOJqaUH3T4imh+8Tf5X9 bY2axc6pBPGXvvhRzr+I+PrtMnSzgFrcca5B4HXNMQT9OM7GkNXahg8MqsIoYOS9 Kob+dvqMJoRN5Cio9xNMkbkKEF0loEeq0uHmhieMKxpqPx1FIRebSx15dLcJ+2Wg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddthedguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepmfhlrghu shculfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrth htvghrnhepjeegudffueeiteekieelkedvueelteevjeduieeludfffeejgeffhfduvddu ffeknecukfhppeektddrudeijedrleekrdduledtnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepihhtshesihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: Received: from apples.localdomain (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id D263E1080063; Tue, 20 Apr 2021 03:16:25 -0400 (EDT) Date: Tue, 20 Apr 2021 09:16:24 +0200 From: Klaus Jensen To: Thomas Huth Subject: Re: [PATCH 01/14] hw/block/nvme: rename __nvme_zrm_open Message-ID: References: <20210419192801.62255-1-its@irrelevant.dk> <20210419192801.62255-2-its@irrelevant.dk> <485ad94d-67fa-32a4-c783-975cca188816@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="j2DwJVitRsZcpjBn" Content-Disposition: inline In-Reply-To: <485ad94d-67fa-32a4-c783-975cca188816@redhat.com> Received-SPF: pass client-ip=64.147.123.20; envelope-from=its@irrelevant.dk; helo=wout4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Klaus Jensen , qemu-devel@nongnu.org, Max Reitz , Keith Busch , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --j2DwJVitRsZcpjBn Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Apr 20 07:53, Thomas Huth wrote: >On 19/04/2021 21.27, Klaus Jensen wrote: >>From: Klaus Jensen >> >>Get rid of the (reserved) double underscore use. >> >>Cc: Philippe Mathieu-Daud=C3=A9 >>Cc: Thomas Huth >>Signed-off-by: Klaus Jensen >>--- >> hw/block/nvme.c | 16 ++++++++++------ >> 1 file changed, 10 insertions(+), 6 deletions(-) > >I think it would be good to mention the change with NVME_ZRM_AUTO in=20 >the patch description, too. > >Apart from that: >Reviewed-by: Thomas Huth > Makes sense, thanks! --j2DwJVitRsZcpjBn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmB+f8UACgkQTeGvMW1P DenRxwf/ZG13KjQ0m1XnhnWYeOgFxjxsb22fB5yXuFMVZU9D5Rj8ic5TC1U6d33A BmxMFSav5W/1fl4by4t0CoPtC64DbBsXcySofCWNgBOF2tf/ZkswDb+lg1aJ0d+b XlSyRSm2wrSexzioelM1NznrjsvfWJrfbN1y7JG4Edoab0T+baufGO1HdZo+1SLV 8SCjh7Fymnv5nIbIPH0ZMDrl5TM89p+jNj3NfcZk+EXYe3A1fRXIyX4YB9XDs5in BzUKYnqMAZYzmcG2/BGmHYVyBsLUemnnxL5QnHcgSwH6AHBzlHX3Hpld/VgKiPAb w9E5mmEKDBn0YslC5B1V2WjsWiDZ8A== =6MvX -----END PGP SIGNATURE----- --j2DwJVitRsZcpjBn--