From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: Eric Auger <eric.auger@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [PATCH 2/3] virtio-iommu: Default to bypass during boot
Date: Fri, 8 Oct 2021 11:21:38 +0100 [thread overview]
Message-ID: <YWAbsnxt2YY4Etbs@myrica> (raw)
In-Reply-To: <8fc7acc5-2ce5-293a-0db3-40ff52b91803@redhat.com>
On Wed, Oct 06, 2021 at 03:04:15PM +0200, Eric Auger wrote:
> > + if (config.bypass != dev->config.bypass) {
> > + if (!virtio_vdev_has_feature(vdev, VIRTIO_IOMMU_F_BYPASS_CONFIG)) {
> > + virtio_error(vdev, "cannot set config.bypass");
> > + return;
> > + }
> > + if (config.bypass != 0 && config.bypass != 1) {
> > + warn_report("invalid config.bypass value '%d'", config.bypass);
> > + dev->config.bypass = 0;
> Shouldn't we leave the old value instead. The spec proposal says it
> takes 0 though.
Yes keeping the old value is better, I'll change the spec. Writing a
different value is a driver bug since new values for the bypass field will
be keyed off a new feature bit.
Thanks,
Jean
next prev parent reply other threads:[~2021-10-08 10:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 18:50 [PATCH 0/3] virtio-iommu: Support VIRTIO_IOMMU_F_BYPASS_CONFIG Jean-Philippe Brucker
2021-09-30 18:50 ` [PATCH 1/3] NOMERGE: virtio-iommu: Add definitions for VIRTIO_IOMMU_F_BYPASS_CONFIG Jean-Philippe Brucker
2021-09-30 18:50 ` [PATCH 2/3] virtio-iommu: Default to bypass during boot Jean-Philippe Brucker
2021-10-06 13:04 ` Eric Auger
2021-10-08 10:21 ` Jean-Philippe Brucker [this message]
2021-09-30 18:50 ` [PATCH 3/3] virtio-iommu: Support bypass domain Jean-Philippe Brucker
2021-10-06 13:10 ` Eric Auger
2022-01-11 9:02 ` [PATCH 0/3] virtio-iommu: Support VIRTIO_IOMMU_F_BYPASS_CONFIG Eric Auger
2022-01-11 10:13 ` Jean-Philippe Brucker
2022-01-11 10:33 ` Eric Auger
2022-01-11 15:40 ` Michael S. Tsirkin
2022-01-11 16:24 ` Jean-Philippe Brucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWAbsnxt2YY4Etbs@myrica \
--to=jean-philippe@linaro.org \
--cc=eric.auger@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).