Re: [PATCH v3] hw/riscv: virt: Assume M-mode FW in pflash0 only when "-bios none"

From: Sunil V L <sunilvl@ventanamicro.com>
To: Andrea Bolognani <abologna@redhat.com>
Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Alistair Francis <alistair.francis@wdc.com>,
	Bin Meng <bin.meng@windriver.com>,
	Weiwei Li <liweiwei@iscas.ac.cn>,
	Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
	Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>
Subject: Re: [PATCH v3] hw/riscv: virt: Assume M-mode FW in pflash0 only when "-bios none"
Date: Thu, 25 May 2023 22:24:37 +0530	[thread overview]
Message-ID: <ZG+SzQYPoyYfMFVi@sunil-laptop> (raw)
In-Reply-To: <CABJz62NUpY35u2ykPXVHp8a_RUyjCnC1_DpWsYNuSBftHe4qBQ@mail.gmail.com>

On Thu, May 25, 2023 at 04:19:12PM +0000, Andrea Bolognani wrote:
> On Thu, May 25, 2023 at 08:32:46PM +0530, Sunil V L wrote:
> > On Thu, May 25, 2023 at 01:43:28PM +0000, Andrea Bolognani wrote:
> > > I have also tried booting an openSUSE Tumbleweed "JeOS" image, since
> > > that's the only distro I'm aware of that uses UEFI boot on RISC-V at
> > > this point - though they use U-Boot's UEFI support rather than edk2.
> > >
> > > During that attempt, I ended up in the edk2 shell. Running
> > >
> > >   fs0:\efi\boot\bootriscv64.efi
> > >
> > > brings up GRUB just fine, but selecting the default boot entry
> > > results in
> > >
> > >   Loading Linux 6.3.2-1-default ...
> > >   Loading initial ramdisk ...
> > >   EFI stub: Booting Linux Kernel...
> > >   EFI stub: Loaded initrd from LINUX_EFI_INITRD_MEDIA_GUID device path
> > >   EFI stub: Generating empty DTB
> > >   EFI stub: Exiting boot services...
> > >
> > > being printed, after which it's back to OpenSBI and from there to
> > > edk2 again.
> >
> > Thanks!. Please add -machine acpi=off in qemu command to boot the
> > kernel.
> 
> Yup, that worked! It booted all the way to the login prompt :)
> 
> Note that libvirt automatically adds acpi=off, so that won't be a
> concern for libvirt users.
> 
Great!. Thanks. Since we decided to keep acpi enabled by default in
qemu similar to other architectures, we need to turn this off until
complete ACPI support is merged in linux kernel. Thanks for the
information that libvirt turns it off by default.

> > > > > Going further and testing libvirt integration. After hacking around
> > > > > other issues, I finally stumbled upon this error:
> > > > >
> > > > >   qemu-system-riscv64: Property 'virt-machine.pflash0' not found
> > > >
> > > > Thanks!. This needs some investigation. Let me look into supporting
> > > > this.
> > >
> > > Yes please! It's critical to libvirt integration. Feel free to CC me
> > > when you post patches and I'll gladly test them.
> >
> > Sure, I have the fix ready. I need to convert this into a patch series
> > now. Will send it soon and thanks in advance for helping with testing.
> 
> Excellent! Looking forward to it :)
> 
Sent.

Thanks,
Sunil