From: John Snow <jsnow@redhat.com>
To: Max Reitz <mreitz@redhat.com>,
Maxim Levitsky <mlevitsk@redhat.com>,
qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,
John Ferlan <jferlan@redhat.com>,
qemu-block@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] block/nvme: add support for discard
Date: Mon, 9 Sep 2019 13:03:47 -0400 [thread overview]
Message-ID: <ad6938d5-0584-55bd-1eb3-1f04bafde126@redhat.com> (raw)
In-Reply-To: <3967d83b-2637-8020-a3b6-f1fa995ad34f@redhat.com>
On 9/9/19 5:25 AM, Max Reitz wrote:
> On 05.09.19 19:27, John Snow wrote:
>
> [...]
>
>> You also probably require review (or at least an ACK) from Keith Busch
>> who maintains this file.
>
> Keith actually maintains the NVMe guest device; technically, Fam is the
> NVMe block driver maintainer.
W h o o p s. Thanks for correcting me.
Well, if it's Fam -- he seems a little busier lately -- it's probably
not so crucial to gate on his approval. I thought it'd be nice to at
least get an ACK from someone who has used this module before, because I
haven't -- I was just giving some style review to help push it along.
(On that note, if you felt like my style review was wrong or isn't worth
doing -- it is always perfectly fair to just say so, along with some
reason as to why you won't -- that way patches won't rot on the list
when people may have gotten the impression that a V2 is warranted.)
--js
next prev parent reply other threads:[~2019-09-09 17:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-25 7:15 [Qemu-devel] [PATCH 0/2] block/nvme: add support for write zeros and discard Maxim Levitsky
2019-08-25 7:15 ` [Qemu-devel] [PATCH 1/2] block/nvme: add support for write zeros Maxim Levitsky
2019-08-27 22:22 ` John Snow
2019-08-28 9:02 ` Maxim Levitsky
2019-09-13 13:30 ` Maxim Levitsky
2019-08-25 7:15 ` [Qemu-devel] [PATCH 2/2] block/nvme: add support for discard Maxim Levitsky
2019-08-27 22:29 ` John Snow
2019-08-28 9:03 ` Maxim Levitsky
2019-09-05 13:24 ` Maxim Levitsky
2019-09-05 17:27 ` John Snow
2019-09-05 17:32 ` Maxim Levitsky
2019-09-09 9:25 ` Max Reitz
2019-09-09 17:03 ` John Snow [this message]
2019-09-10 14:49 ` Paolo Bonzini
2019-09-10 14:57 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad6938d5-0584-55bd-1eb3-1f04bafde126@redhat.com \
--to=jsnow@redhat.com \
--cc=fam@euphon.net \
--cc=jferlan@redhat.com \
--cc=kwolf@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).