qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Richard Henderson" <richard.henderson@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, Wei Yang <richardw.yang@linux.intel.com>
Subject: Re: [PATCH v2 1/7] cpu: use ROUND_UP() to define xxx_PAGE_ALIGN
Date: Thu, 24 Oct 2019 16:14:04 +0200	[thread overview]
Message-ID: <af5b2cb5-49b5-68c2-e55b-a1077ad4df28@redhat.com> (raw)
In-Reply-To: <26cb0551-fbac-e059-c1bf-9c17420528b7@linaro.org>

On 24/10/19 16:06, Richard Henderson wrote:
> On 10/24/19 8:04 AM, Paolo Bonzini wrote:
>> On 24/10/19 13:52, Philippe Mathieu-Daudé wrote:
>>>> diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
>>>> index ad9ab85eb3..255bb186ac 100644
>>>> --- a/include/exec/cpu-all.h
>>>> +++ b/include/exec/cpu-all.h
>>>> @@ -220,7 +220,7 @@ extern int target_page_bits;
>>>>     #define TARGET_PAGE_SIZE (1 << TARGET_PAGE_BITS)
>>>>   #define TARGET_PAGE_MASK ~(TARGET_PAGE_SIZE - 1)
>>>> -#define TARGET_PAGE_ALIGN(addr) (((addr) + TARGET_PAGE_SIZE - 1) &
>>>> TARGET_PAGE_MASK)
>>>> +#define TARGET_PAGE_ALIGN(addr) ROUND_UP((addr), TARGET_PAGE_SIZE)
>>>>     /* Using intptr_t ensures that qemu_*_page_mask is sign-extended even
>>>>    * when intptr_t is 32-bit and we are aligning a long long.
>>>> @@ -228,9 +228,8 @@ extern int target_page_bits;
>>>>   extern uintptr_t qemu_host_page_size;
>>>>   extern intptr_t qemu_host_page_mask;
>>>>   -#define HOST_PAGE_ALIGN(addr) (((addr) + qemu_host_page_size - 1) &
>>>> qemu_host_page_mask)
>>>> -#define REAL_HOST_PAGE_ALIGN(addr) (((addr) +
>>>> qemu_real_host_page_size - 1) & \
>>>> -                                    qemu_real_host_page_mask)
>>>> +#define HOST_PAGE_ALIGN(addr) ROUND_UP((addr), qemu_host_page_size)
>>>> +#define REAL_HOST_PAGE_ALIGN(addr) ROUND_UP((addr),
>>>> qemu_real_host_page_size)
>>>>     /* same as PROT_xxx */
>>>>   #define PAGE_READ      0x0001
>>>>
>>
>> Isn't this the patch where Richard pointed out that the compiler
>> generates worse code?
> 
> Richard confused ROUND_UP with QEMU_ALIGN_UP.

Uh, those are both really badly named.  Especially considering that
DIV_ROUND_UP divides the result of QEMU_ALIGN_UP.  Should we consider
swapping them?!?

Paolo



  reply	other threads:[~2019-10-24 15:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 15:44 [PATCH v2 0/7] exec: Improve code for TARGET_PAGE_BITS_VARY Richard Henderson
2019-10-23 15:44 ` [PATCH v2 1/7] cpu: use ROUND_UP() to define xxx_PAGE_ALIGN Richard Henderson
2019-10-24 11:52   ` Philippe Mathieu-Daudé
2019-10-24 12:04     ` Paolo Bonzini
2019-10-24 14:06       ` Richard Henderson
2019-10-24 14:14         ` Paolo Bonzini [this message]
2019-10-25 11:48           ` Richard Henderson
2019-10-23 15:45 ` [PATCH v2 2/7] exec: Split out variable page size support to exec-vary.c Richard Henderson
2019-10-25 14:02   ` Alex Bennée
2019-10-23 15:45 ` [PATCH v2 3/7] configure: Detect compiler support for __attribute__((alias)) Richard Henderson
2019-10-25 14:04   ` Alex Bennée
2019-11-08 16:01     ` Thomas Huth
2019-10-23 15:45 ` [PATCH v2 4/7] exec: Use const alias for TARGET_PAGE_BITS_VARY Richard Henderson
2019-10-25 14:28   ` Alex Bennée
2019-10-25 14:51   ` Peter Maydell
2019-10-25 20:43     ` Richard Henderson
2019-10-25 21:01       ` Peter Maydell
2019-10-25 21:16         ` Richard Henderson
2019-10-23 15:45 ` [PATCH v2 5/7] exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG Richard Henderson
2019-10-25 14:44   ` Alex Bennée
2019-10-23 15:45 ` [PATCH v2 6/7] exec: Promote TARGET_PAGE_MASK to target_long Richard Henderson
2019-10-23 15:45 ` [PATCH v2 7/7] exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY Richard Henderson
2019-10-24  9:29 ` [PATCH v2 0/7] exec: Improve code " no-reply
2019-10-25 13:57 ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af5b2cb5-49b5-68c2-e55b-a1077ad4df28@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=richardw.yang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).