From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9DC8ECDE27 for ; Wed, 11 Sep 2019 09:23:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE8F321928 for ; Wed, 11 Sep 2019 09:23:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE8F321928 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sipsolutions.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7yqD-0007su-IE for qemu-devel@archiver.kernel.org; Wed, 11 Sep 2019 05:23:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40941) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7yns-00053t-UX for qemu-devel@nongnu.org; Wed, 11 Sep 2019 05:20:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i7ynr-000805-Rc for qemu-devel@nongnu.org; Wed, 11 Sep 2019 05:20:44 -0400 Received: from s3.sipsolutions.net ([2a01:4f8:191:4433::2]:49978 helo=sipsolutions.net) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i7ynr-0007z6-KO for qemu-devel@nongnu.org; Wed, 11 Sep 2019 05:20:43 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1i7ynp-0002Vk-Lk; Wed, 11 Sep 2019 11:20:41 +0200 Message-ID: From: Johannes Berg To: "Michael S. Tsirkin" Date: Wed, 11 Sep 2019 11:20:40 +0200 In-Reply-To: <20190911051236-mutt-send-email-mst@kernel.org> References: <20190906110340-mutt-send-email-mst@kernel.org> <20190908091207-mutt-send-email-mst@kernel.org> <8a9cf8a1726afce7fed8992a4f19fc808004ef88.camel@sipsolutions.net> <20190909083902-mutt-send-email-mst@kernel.org> <89f25546ffa71c799c533e50658a3a58e066f436.camel@sipsolutions.net> <20190909094609-mutt-send-email-mst@kernel.org> <1f28c61e5caf6fc2a2125664043d1f7b9b769149.camel@sipsolutions.net> <20190911051236-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a01:4f8:191:4433::2 Subject: Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > Each feature is documented near the description of the functionality it > enables, that can work for this. Hmm, so you mean I should add a section on in-band notifications, and document things there? > I don't much like F_KICK_CALL_MSGS as > not generic enough but it's not simulation as such: > IN_BAND_NOTIFICATIONS? Sure, sounds good to me, I guess I'm not good at naming things :) > As for how to handle errors, that probably belongs near > "Communication". > > Or maybe add a new "Error handling" section. OK. Btw, I tried this yesterday in libvhost-user, but if I just do vu_panic() it just aborts that message handling and hangs, if I forcefully close the FD then it ends up crashing later ... I'm tempted to go with vu_panic() only for now as that seems to be the normal way to handle unexpected protocol errors there, many such other errors probably should also close the FD? johannes