From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Sunil V L <sunilvl@ventanamicro.com>, qemu-riscv@nongnu.org
Cc: qemu-devel@nongnu.org, Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <alistair.francis@wdc.com>,
Bin Meng <bin.meng@windriver.com>,
Weiwei Li <liweiwei@iscas.ac.cn>,
Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,
Andrea Bolognani <abologna@redhat.com>
Subject: Re: [PATCH v5 2/3] riscv/virt: Support using pflash via -blockdev option
Date: Fri, 26 May 2023 16:04:34 +0200 [thread overview]
Message-ID: <c267b027-5b60-ad39-2940-6960be1fb7ba@linaro.org> (raw)
In-Reply-To: <20230526121006.76388-3-sunilvl@ventanamicro.com>
On 26/5/23 14:10, Sunil V L wrote:
> Currently, pflash devices can be configured only via -pflash
> or -drive options. This is the legacy way and the
> better way is to use -blockdev as in other architectures.
> libvirt also has moved to use -blockdev method.
>
> To support -blockdev option, pflash devices need to be
> created in instance_init itself. So, update the code to
> move the virt_flash_create() to instance_init. Also, use
> standard interfaces to detect whether pflash0 is
> configured or not.
>
> Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> Reported-by: Andrea Bolognani <abologna@redhat.com>
> Tested-by: Andrea Bolognani <abologna@redhat.com>
> ---
> hw/riscv/virt.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-05-26 14:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 12:10 [PATCH v5 0/3] hw/riscv/virt: pflash improvements Sunil V L
2023-05-26 12:10 ` [PATCH v5 1/3] hw/riscv: virt: Assume M-mode FW in pflash0 only when "-bios none" Sunil V L
2023-05-26 12:10 ` [PATCH v5 2/3] riscv/virt: Support using pflash via -blockdev option Sunil V L
2023-05-26 14:04 ` Philippe Mathieu-Daudé [this message]
2023-05-26 12:10 ` [PATCH v5 3/3] docs/system: riscv: Add pflash usage details Sunil V L
2023-05-26 14:04 ` Philippe Mathieu-Daudé
2023-05-26 12:47 ` [PATCH v5 0/3] hw/riscv/virt: pflash improvements Andrea Bolognani
2023-05-31 5:16 ` Anup Patel
2023-05-31 11:34 ` Andrea Bolognani
2023-05-31 13:48 ` Sunil V L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c267b027-5b60-ad39-2940-6960be1fb7ba@linaro.org \
--to=philmd@linaro.org \
--cc=abologna@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=dbarboza@ventanamicro.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sunilvl@ventanamicro.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).