From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
Andrew Jeffery <andrew@aj.id.au>
Cc: qemu-arm <qemu-arm@nongnu.org>, "Joel Stanley" <joel@jms.id.au>,
"Cédric Le Goater" <clg@kaod.org>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v5] target-arm: Make the counter tick relative to cntfrq
Date: Tue, 17 Sep 2019 12:25:49 -0700 [thread overview]
Message-ID: <c9f58ca3-36ee-e8bb-a350-29729f4f24df@linaro.org> (raw)
In-Reply-To: <CAFEAcA_h80VQVC0jE7v8kmsuXU=16+KXSKQ-qhuRNTct7X6X7g@mail.gmail.com>
On 9/17/19 12:14 PM, Peter Maydell wrote:
>> +static Property arm_cpu_gt_cntfrq_property =
>> + DEFINE_PROP_UINT64("cntfrq", ARMCPU, gt_cntfrq,
>> + (1000 * 1000 * 1000) / GTIMER_SCALE);
> I think it would be helpful to have a comment saynig what units
> this property is in.
>
Should this be NANOSECONDS_PER_SECOND?
It's certainly a suspicious use of 1e9 otherwise.
r~
next prev parent reply other threads:[~2019-09-17 19:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 6:56 [Qemu-devel] [PATCH v5] target-arm: Make the counter tick relative to cntfrq Andrew Jeffery
2019-09-17 16:14 ` Peter Maydell
2019-09-17 19:25 ` Richard Henderson [this message]
2019-09-20 6:14 ` Andrew Jeffery
2019-09-20 6:09 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9f58ca3-36ee-e8bb-a350-29729f4f24df@linaro.org \
--to=richard.henderson@linaro.org \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).