From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
To: Kevin Wolf <kwolf@redhat.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"mreitz@redhat.com" <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block/null: Expose read-zeroes option in QAPI schema
Date: Mon, 24 Jun 2019 09:11:43 +0000 [thread overview]
Message-ID: <d98be8d7-1d08-6491-b456-d10b4db8e530@virtuozzo.com> (raw)
In-Reply-To: <20190617115721.27525-1-kwolf@redhat.com>
On 17/06/2019 14:57, Kevin Wolf wrote:
> Commit cd219eb1e55 added the read-zeroes option for the null-co and
> null-aio block driver, but forgot to add them to the QAPI schema.
> Therefore, this option wasn't available in -blockdev and blockdev-add
> until now.
>
> Add the missing option in the schema to make it available there, too.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> qapi/block-core.json | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 61124431d8..0d43d4f37c 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2890,11 +2890,13 @@
> # @latency-ns: emulated latency (in nanoseconds) in processing
> # requests. Default to zero which completes requests immediately.
> # (Since 2.4)
> +# @read-zeroes: if true, reads from the device produce zeroes; if false, the
> +# buffer is left unchanged. (default: false; since: 4.1)
> #
> # Since: 2.9
> ##
> { 'struct': 'BlockdevOptionsNull',
> - 'data': { '*size': 'int', '*latency-ns': 'uint64' } }
> + 'data': { '*size': 'int', '*latency-ns': 'uint64', '*read-zeroes': 'bool' } }
>
> ##
> # @BlockdevOptionsNVMe:
>
Reviewed-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
prev parent reply other threads:[~2019-06-24 9:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 11:57 [Qemu-devel] [PATCH] block/null: Expose read-zeroes option in QAPI schema Kevin Wolf
2019-06-17 12:28 ` Max Reitz
2019-06-24 9:11 ` Andrey Shinkevich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d98be8d7-1d08-6491-b456-d10b4db8e530@virtuozzo.com \
--to=andrey.shinkevich@virtuozzo.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).