From: "Cédric Le Goater" <clg@kaod.org>
To: Nicholas Piggin <npiggin@gmail.com>,
David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Greg Kurz <groug@kaod.org>
Subject: Re: [Qemu-devel] [PATCH v5 2/4] spapr: Implement H_PROD
Date: Wed, 17 Jul 2019 12:16:44 +0200 [thread overview]
Message-ID: <dcb80cc9-b282-dd27-5e09-1f96751be689@kaod.org> (raw)
In-Reply-To: <20190717053952.13729-3-npiggin@gmail.com>
On 17/07/2019 07:39, Nicholas Piggin wrote:
> H_PROD is added, and H_CEDE is modified to test the prod bit
> according to PAPR.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> hw/ppc/spapr_hcall.c | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
> index e615881ac4..8b208ab259 100644
> --- a/hw/ppc/spapr_hcall.c
> +++ b/hw/ppc/spapr_hcall.c
> @@ -1050,14 +1050,41 @@ static target_ulong h_cede(PowerPCCPU *cpu, SpaprMachineState *spapr,
> {
> CPUPPCState *env = &cpu->env;
> CPUState *cs = CPU(cpu);
> + SpaprCpuState *spapr_cpu = spapr_cpu_state(cpu);
>
> env->msr |= (1ULL << MSR_EE);
> hreg_compute_hflags(env);
> +
> + if (spapr_cpu->prod) {
> + spapr_cpu->prod = false;
> + return H_SUCCESS;
> + }
> +
> if (!cpu_has_work(cs)) {
> cs->halted = 1;
> cs->exception_index = EXCP_HLT;
> cs->exit_request = 1;
> }
> +
> + return H_SUCCESS;
> +}
> +
> +static target_ulong h_prod(PowerPCCPU *cpu, SpaprMachineState *spapr,
> + target_ulong opcode, target_ulong *args)
> +{
> + target_long target = args[0];
> + CPUState *cs;
> + SpaprCpuState *spapr_cpu = spapr_cpu_state(cpu);
shouldn't we grab the SpaprCpuState of 'target' instead ?
> + cs = CPU(spapr_find_cpu(target));
> + if (!cs) {
> + return H_PARAMETER;
> + }
> +
> + spapr_cpu->prod = true;
> + cs->halted = 0;
> + qemu_cpu_kick(cs);
> +
> return H_SUCCESS;
> }
>
> @@ -1882,6 +1909,8 @@ static void hypercall_register_types(void)
> /* hcall-splpar */
> spapr_register_hypercall(H_REGISTER_VPA, h_register_vpa);
> spapr_register_hypercall(H_CEDE, h_cede);
> + spapr_register_hypercall(H_PROD, h_prod);
> +
> spapr_register_hypercall(H_SIGNAL_SYS_RESET, h_signal_sys_reset);
>
> /* processor register resource access h-calls */
>
next prev parent reply other threads:[~2019-07-17 10:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 5:39 [Qemu-devel] [PATCH v5 0/4] spapr: implement dispatch and suspend calls Nicholas Piggin
2019-07-17 5:39 ` [Qemu-devel] [PATCH v5 1/4] spapr: Implement VPA dispatch counter and prod bit on tcg Nicholas Piggin
2019-07-17 12:50 ` Cédric Le Goater
2019-07-18 2:17 ` Nicholas Piggin
2019-07-17 15:29 ` Greg Kurz
2019-07-18 2:18 ` Nicholas Piggin
2019-07-17 5:39 ` [Qemu-devel] [PATCH v5 2/4] spapr: Implement H_PROD Nicholas Piggin
2019-07-17 10:16 ` Cédric Le Goater [this message]
2019-07-17 11:06 ` Nicholas Piggin
2019-07-17 13:33 ` Cédric Le Goater
2019-07-18 2:24 ` Nicholas Piggin
2019-07-17 5:39 ` [Qemu-devel] [PATCH v5 3/4] spapr: Implement H_CONFER Nicholas Piggin
2019-07-17 17:00 ` Greg Kurz
2019-07-18 2:19 ` Nicholas Piggin
2019-07-17 5:39 ` [Qemu-devel] [PATCH v5 4/4] spapr: Implement H_JOIN Nicholas Piggin
2019-07-17 17:30 ` Greg Kurz
2019-07-18 2:25 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcb80cc9-b282-dd27-5e09-1f96751be689@kaod.org \
--to=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).