From: Helge Deller <deller@gmx.de>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Sven Schnelle" <svens@stackframe.org>,
qemu-devel@nongnu.org
Cc: Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH 1/4] hw/hppa/dino: Add comments with register name
Date: Sat, 15 Feb 2020 20:59:05 +0100 [thread overview]
Message-ID: <ddc10c9d-43b3-bdec-01f9-9db4a5e77c92@gmx.de> (raw)
In-Reply-To: <20200213234148.8434-2-f4bug@amsat.org>
On 14.02.20 00:41, Philippe Mathieu-Daudé wrote:
> Add a comment with the name of each register in the 0x800-0x833 range.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Acked-by: Helge Deller <deller@gmx.de>
> ---
> hw/hppa/dino.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c
> index 9797a7f0d9..c237ad3b1b 100644
> --- a/hw/hppa/dino.c
> +++ b/hw/hppa/dino.c
> @@ -85,18 +85,18 @@
>
> #define DINO800_REGS ((DINO_TLTIM - DINO_GMASK) / 4)
> static const uint32_t reg800_keep_bits[DINO800_REGS] = {
> - MAKE_64BIT_MASK(0, 1),
> - MAKE_64BIT_MASK(0, 7),
> - MAKE_64BIT_MASK(0, 7),
> - MAKE_64BIT_MASK(0, 8),
> - MAKE_64BIT_MASK(0, 7),
> - MAKE_64BIT_MASK(0, 9),
> - MAKE_64BIT_MASK(0, 32),
> - MAKE_64BIT_MASK(0, 8),
> - MAKE_64BIT_MASK(0, 30),
> - MAKE_64BIT_MASK(0, 25),
> - MAKE_64BIT_MASK(0, 22),
> - MAKE_64BIT_MASK(0, 9),
> + MAKE_64BIT_MASK(0, 1), /* GMASK */
> + MAKE_64BIT_MASK(0, 7), /* PAMR */
> + MAKE_64BIT_MASK(0, 7), /* PAPR */
> + MAKE_64BIT_MASK(0, 8), /* DAMODE */
> + MAKE_64BIT_MASK(0, 7), /* PCICMD */
> + MAKE_64BIT_MASK(0, 9), /* PCISTS */
> + MAKE_64BIT_MASK(0, 32), /* Undefined */
> + MAKE_64BIT_MASK(0, 8), /* MLTIM */
> + MAKE_64BIT_MASK(0, 30), /* BRDG_FEAT */
> + MAKE_64BIT_MASK(0, 25), /* PCIROR */
> + MAKE_64BIT_MASK(0, 22), /* PCIWOR */
> + MAKE_64BIT_MASK(0, 9), /* TLTIM */
> };
>
> typedef struct DinoState {
>
next prev parent reply other threads:[~2020-02-15 20:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 23:41 [PATCH 0/4] hw/hppa/dino: Fix Coverity 1419393 & 1419394 Philippe Mathieu-Daudé
2020-02-13 23:41 ` [PATCH 1/4] hw/hppa/dino: Add comments with register name Philippe Mathieu-Daudé
2020-02-15 19:59 ` Helge Deller [this message]
2020-02-13 23:41 ` [PATCH 2/4] hw/hppa/dino: Fix reg800_keep_bits[] overrun (CID 1419393 & 1419394) Philippe Mathieu-Daudé
2020-02-15 20:08 ` Helge Deller
2020-02-17 17:37 ` Peter Maydell
2020-02-18 6:19 ` Philippe Mathieu-Daudé
2020-02-18 6:28 ` Philippe Mathieu-Daudé
2020-02-13 23:41 ` [RFC PATCH 3/4] hw/hppa/dino: Fix PCIROR register access bitmask Philippe Mathieu-Daudé
2020-02-15 20:49 ` Helge Deller
2020-02-13 23:41 ` [RFC PATCH 4/4] hw/hppa/dino: Do not accept accesses to registers 0x818 and 0x82c Philippe Mathieu-Daudé
2020-02-15 20:49 ` Helge Deller
2020-02-16 1:44 ` [PATCH 0/4] hw/hppa/dino: Fix Coverity 1419393 & 1419394 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddc10c9d-43b3-bdec-01f9-9db4a5e77c92@gmx.de \
--to=deller@gmx.de \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).