From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22220C3A5A2 for ; Fri, 23 Aug 2019 15:23:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9BE22133F for ; Fri, 23 Aug 2019 15:23:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="C71Ul2TV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9BE22133F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1BPu-0000WU-Vj for qemu-devel@archiver.kernel.org; Fri, 23 Aug 2019 11:23:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59313) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1BOq-0007xE-Qu for qemu-devel@nongnu.org; Fri, 23 Aug 2019 11:22:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1BOp-0007ig-TP for qemu-devel@nongnu.org; Fri, 23 Aug 2019 11:22:48 -0400 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]:40790) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1BOp-0007iA-Lg for qemu-devel@nongnu.org; Fri, 23 Aug 2019 11:22:47 -0400 Received: by mail-pf1-x442.google.com with SMTP id w16so6665135pfn.7 for ; Fri, 23 Aug 2019 08:22:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JR/xbsJbdGvh4q5foqnF1z50zj2S+UxaaH4oXYc5/b8=; b=C71Ul2TVFIBHxlGe6orpS/IY68iM5ZhTyA2g0q3SipzS/hLVuEXYKBee+rlN1Lq7I5 iuF7n2eeFCJipsrjEcGCG9gRxrBqSEdrE/Q0dhJB1yrdqKVT4GxwvfiXzgJeLN9ZZNU7 hyASpeLGRvJ8HRt2br1iTl1iEiK9Wlv/mcmxmNQZweT/UCizi1KNvV1LE/swVcPfyKx1 d3x6D/Syb7pWy3R+QQ+ld7sgPygND4gSfAn4vXqdz2W37RVKFShq02gNd+Et36kvlpoY Mdu3OmZQY9OLM64Q6+SKhGVFund0OcVRxrCEQhesACqZMIW4flvv2R5IyZgY1UTscjTd 5ffA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JR/xbsJbdGvh4q5foqnF1z50zj2S+UxaaH4oXYc5/b8=; b=ZH42QYgaKPY/+qDmPAxNZsd+K3/vrvWMV75JaK0l/c3k/xPewXK2+BcqA3kdVggYmx nWunzLRN3ctLWYxmFilRIqjKfzehrELW9p1zE8fdmBL14Lo2AQ6+YB/hDDwyweG3lj3m EQRKlgWSbylGekX45RfihZPc6X6rFpM3fFc5aXRRDApygBKQRmIxApFQh4Z69YGOwCNi nim7abVx3KL2bG8EXhXlX5X9c6PPn6kCaXFqIXAyIZwxKkKUnVzZWk+erK7wPDPvIL8Q krE2TvvuxQeEbdWic0pZX5JrqaWqi8TN5SvwcfPIALNPAEwZ/ahwjr7soLGtmFZIT+vs IIQg== X-Gm-Message-State: APjAAAXbMXkdcUN04yP8ER4JhE2Ql3XwXA1tC3zis+dzvEnBGXSlnc8k DvtuuddwTW8Np3gNxBv1qHr6xw== X-Google-Smtp-Source: APXvYqw67mn/C6o2B6Hhuu5yLbtbFiuncxxwnfvs1PLV5R+P3wDBwHIDnU1c81ew3pLC4f4DPqnhoQ== X-Received: by 2002:a63:a35e:: with SMTP id v30mr4313148pgn.129.1566573766163; Fri, 23 Aug 2019 08:22:46 -0700 (PDT) Received: from [192.168.1.11] (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id 185sm3001557pfd.125.2019.08.23.08.22.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Aug 2019 08:22:45 -0700 (PDT) To: David Hildenbrand , qemu-devel@nongnu.org References: <20190823100741.9621-1-david@redhat.com> <20190823100741.9621-4-david@redhat.com> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: Date: Fri, 23 Aug 2019 08:22:43 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190823100741.9621-4-david@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::442 Subject: Re: [Qemu-devel] [PATCH v1 3/9] tcg: Factor out CONFIG_USER_ONLY probe_write() from s390x code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Cornelia Huck , Eduardo Habkost , Aleksandar Rikalo , Riku Voipio , qemu-s390x@nongnu.org, Aleksandar Markovic , Paolo Bonzini , Aurelien Jarno , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/23/19 3:07 AM, David Hildenbrand wrote: > +void probe_write(CPUArchState *env, target_ulong addr, int size, int mmu_idx, > + uintptr_t retaddr) > +{ > + CPUState *cpu = env_cpu(env); > + CPUClass *cc; > + > + if (!guest_addr_valid(addr) || > + (size > 0 && !guest_addr_valid(addr + size - 1)) || I think the interface needs to remain the same between softmmu and linux-user, and we should not allow size to cross a page here either. Which also means that the second line here can go away -- we only need the one test vs the single page. r~