From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com, kwolf@pond.sub.org
Subject: Re: [PATCH 1/6] qapi: Tweak "command returns a nice type" check for clarity
Date: Wed, 20 Nov 2019 13:08:13 -0600 [thread overview]
Message-ID: <e3f3ec9d-d95d-831a-90b4-05f79d1b3ff9@redhat.com> (raw)
In-Reply-To: <20191120182551.23795-2-armbru@redhat.com>
On 11/20/19 12:25 PM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> scripts/qapi/schema.py | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py
> index cf0045f34e..cfb574c85d 100644
> --- a/scripts/qapi/schema.py
> +++ b/scripts/qapi/schema.py
> @@ -711,10 +711,11 @@ class QAPISchemaCommand(QAPISchemaEntity):
> self.ret_type = schema.resolve_type(
> self._ret_type_name, self.info, "command's 'returns'")
> if self.name not in self.info.pragma.returns_whitelist:
> - if not (isinstance(self.ret_type, QAPISchemaObjectType)
> - or (isinstance(self.ret_type, QAPISchemaArrayType)
> - and isinstance(self.ret_type.element_type,
> - QAPISchemaObjectType))):
> + typ = self.ret_type
> + if isinstance(typ, QAPISchemaArrayType):
> + typ = self.ret_type.element_type
> + assert typ
> + if not isinstance(typ, QAPISchemaObjectType):
> raise QAPISemError(
> self.info,
> "command's 'returns' cannot take %s"
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2019-11-20 19:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 18:25 [PATCH 0/6] qapi: Module fixes and cleanups Markus Armbruster
2019-11-20 18:25 ` [PATCH 1/6] qapi: Tweak "command returns a nice type" check for clarity Markus Armbruster
2019-11-20 19:08 ` Eric Blake [this message]
2019-11-20 18:25 ` [PATCH 2/6] tests/Makefile.include: Fix missing test-qapi-emit-events.[ch] Markus Armbruster
2019-11-20 19:16 ` Eric Blake
2019-11-20 18:25 ` [PATCH 3/6] qapi: Generate command registration stuff into separate files Markus Armbruster
2019-11-20 19:26 ` Eric Blake
2019-11-27 16:12 ` Markus Armbruster
2019-11-20 18:25 ` [PATCH 4/6] qapi: Proper intermediate representation for modules Markus Armbruster
2019-11-20 20:31 ` Eric Blake
2019-11-20 18:25 ` [PATCH 5/6] qapi: Fix code generation for empty modules Markus Armbruster
2019-11-20 20:35 ` Eric Blake
2019-11-20 18:25 ` [PATCH 6/6] qapi: Simplify QAPISchemaModularCVisitor Markus Armbruster
2019-11-20 20:54 ` Eric Blake
2019-11-20 19:40 ` [PATCH 0/6] qapi: Module fixes and cleanups Markus Armbruster
2019-11-20 23:58 ` no-reply
2019-11-21 6:27 ` Markus Armbruster
2019-11-29 9:59 ` [PATCH 7/6] Makefile: Make Makefile depend on generated qga files, too Markus Armbruster
2019-12-03 22:33 ` Eric Blake
2019-12-04 6:56 ` Markus Armbruster
2019-12-04 12:58 ` Eric Blake
2019-12-04 13:19 ` Markus Armbruster
2019-12-03 9:01 ` [PATCH 0/6] qapi: Module fixes and cleanups Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3f3ec9d-d95d-831a-90b4-05f79d1b3ff9@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@pond.sub.org \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).