From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A89FC4CECE for ; Mon, 14 Oct 2019 14:08:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D52752083B for ; Mon, 14 Oct 2019 14:08:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D52752083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iK11B-0002TF-Oi for qemu-devel@archiver.kernel.org; Mon, 14 Oct 2019 10:08:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44575) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iK0uM-0004NG-DJ for qemu-devel@nongnu.org; Mon, 14 Oct 2019 10:01:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iK0uL-00089l-2Y for qemu-devel@nongnu.org; Mon, 14 Oct 2019 10:01:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9908) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iK0uC-000828-91; Mon, 14 Oct 2019 10:01:02 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 62DE020FD; Mon, 14 Oct 2019 14:00:56 +0000 (UTC) Received: from [10.3.116.168] (ovpn-116-168.phx2.redhat.com [10.3.116.168]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EDD0E5C541; Mon, 14 Oct 2019 14:00:19 +0000 (UTC) Subject: Re: [RFC v5 025/126] scripts: add coccinelle script to use auto propagated errp To: Vladimir Sementsov-Ogievskiy , "qemu-devel@nongnu.org" References: <20191011160552.22907-1-vsementsov@virtuozzo.com> <20191011160552.22907-26-vsementsov@virtuozzo.com> <5dd4d642-7ea6-42a2-66fc-6d6710b77b8d@redhat.com> <6856bd09-65fc-30d7-2a3c-c85334a024e9@virtuozzo.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Mon, 14 Oct 2019 09:00:19 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <6856bd09-65fc-30d7-2a3c-c85334a024e9@virtuozzo.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.71]); Mon, 14 Oct 2019 14:00:57 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Hajnoczi , Jeff Cody , Jan Kiszka , Alberto Garcia , Hailiang Zhang , "qemu-block@nongnu.org" , Aleksandar Rikalo , Halil Pasic , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Anthony Perard , Samuel Thibault , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Anthony Green , Laurent Vivier , Eduardo Habkost , Xie Changlong , Peter Lieven , "Dr. David Alan Gilbert" , Beniamino Galvani , Eric Auger , Alex Williamson , Ronnie Sahlberg , John Snow , Richard Henderson , Kevin Wolf , Andrew Jeffery , Chris Wulff , Subbaraya Sundeep , Michael Walle , "qemu-ppc@nongnu.org" , Bastian Koppelmann , Igor Mammedov , Fam Zheng , Peter Maydell , "sheepdog@lists.wpkg.org" , Matthew Rosato , David Hildenbrand , Palmer Dabbelt , Thomas Huth , Max Filippov , Hannes Reinecke , Stefano Stabellini , "Gonglei \(Arei\)" , Liu Yuan , Artyom Tarasenko , Eric Farman , Amit Shah , Stefan Weil , Greg Kurz , Yuval Shaia , "qemu-s390x@nongnu.org" , "qemu-arm@nongnu.org" , Peter Chubb , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Stafford Horne , "qemu-riscv@nongnu.org" , Cornelia Huck , Aleksandar Markovic , Aurelien Jarno , Paul Burton , Sagar Karandikar , Paul Durrant , Jason Wang , Gerd Hoffmann , "Edgar E. Iglesias" , Guan Xuetao , Ari Sundholm , Juan Quintela , Michael Roth , Christian Borntraeger , Joel Stanley , Jason Dillaman , Antony Pavlov , "xen-devel@lists.xenproject.org" , "integration@gluster.org" , Laszlo Ersek , "Richard W.M. Jones" , Andrew Baumann , Max Reitz , Denis Lunev , "Michael S. Tsirkin" , Mark Cave-Ayland , Vincenzo Maffione , Marek Vasut , "armbru@redhat.com" , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Alistair Francis , Pavel Dovgalyuk , Giuseppe Lettieri , Luigi Rizzo , David Gibson , Tony Krowiak , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Xiao Guangrong , Pierre Morel , Wen Congyang , Jean-Christophe Dubois , Paolo Bonzini , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/14/19 3:19 AM, Vladimir Sementsov-Ogievskiy wrote: >>> +| >>> +-=C2=A0=C2=A0=C2=A0 error_propagate(errp, local_err); >>> +) >>> +=C2=A0=C2=A0=C2=A0=C2=A0 ...> >>> + } >>> + >> >> It looks like once this script is run, error_propagate_prepend() will = have no clients. >=20 > No, it still have a bit, when working with error_copy, and/or moving er= rors from/to structures. No public clients. So can we turn it into a static function only used by=20 error.c? >=20 >> Is there a non-generated cleanup patch that removes it (and once it is= removed, it can also be removed from the .cocci script as no further cli= ents will reappear later)? >=20 > Maybe. >=20 Basically, if we can get error_propagate out of error.h, that's a good=20 sign. But it's not a show-stopper if we can't do it for some legitimate=20 reason (such a reason might include that the definition of the=20 ERRP_AUTO_PROPAGATE macro is easier to write if error_propagate remains=20 in the .h), so we'll just have to see what is possible. --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org