From: Eric Blake <eblake@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Aleksandar Markovic <amarkovic@wavecomp.com>,
qemu-block@nongnu.org, qemu-trivial@nongnu.org,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH v2 2/3] hw/mips/gt64xxx: Remove dynamic field width from trace events
Date: Fri, 8 Nov 2019 09:58:51 -0600 [thread overview]
Message-ID: <ead1eb4b-a0e0-edf9-8323-ce9f5a291547@redhat.com> (raw)
In-Reply-To: <20191108144042.30245-3-philmd@redhat.com>
On 11/8/19 8:40 AM, Philippe Mathieu-Daudé wrote:
> Since not all trace backends support dynamic field width in
> format (dtrace via stap does not), replace by a static field
> width instead.
>
> Reported-by: Eric Blake <eblake@redhat.com>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1844817
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: Do not update qemu_log_mask()
> ---
> hw/mips/gt64xxx_pci.c | 16 ++++++++--------
> hw/mips/trace-events | 4 ++--
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c
> index 5cab9c1ee1..6743e7c929 100644
> --- a/hw/mips/gt64xxx_pci.c
> +++ b/hw/mips/gt64xxx_pci.c
> @@ -642,19 +642,19 @@ static void gt64120_writel(void *opaque, hwaddr addr,
> /* not really implemented */
> s->regs[saddr] = ~(~(s->regs[saddr]) | ~(val & 0xfffffffe));
> s->regs[saddr] |= !!(s->regs[saddr] & 0xfffffffe);
> - trace_gt64120_write("INTRCAUSE", size << 1, val);
> + trace_gt64120_write("INTRCAUSE", size << 3, val);
Again, this isn't mentioned in the commit message. Why are you changing
parameter values?
> +++ b/hw/mips/trace-events
> @@ -1,4 +1,4 @@
> # gt64xxx.c
> -gt64120_read(const char *regname, int width, uint64_t value) "gt64120 read %s value:0x%0*" PRIx64
> -gt64120_write(const char *regname, int width, uint64_t value) "gt64120 write %s value:0x%0*" PRIx64
> +gt64120_read(const char *regname, int width, uint64_t value) "gt64120 read %s width:%d value:0x%08" PRIx64
> +gt64120_write(const char *regname, int width, uint64_t value) "gt64120 write %s width:%d value:0x%08" PRIx64
Huh, we were really broken - the old code (if passed to printf) would
try to parse 4 parameters, even though it was only passed 3. But it
looks like you still need a v3.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2019-11-08 16:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 14:40 [PATCH v2 0/3] hw: Remove dynamic field width from trace events Philippe Mathieu-Daudé
2019-11-08 14:40 ` [PATCH v2 1/3] hw/block/pflash: " Philippe Mathieu-Daudé
2019-11-08 15:56 ` Eric Blake
2019-11-14 21:26 ` Philippe Mathieu-Daudé
2019-11-18 19:21 ` Eric Blake
2019-11-18 20:39 ` Philippe Mathieu-Daudé
2019-11-08 14:40 ` [PATCH v2 2/3] hw/mips/gt64xxx: " Philippe Mathieu-Daudé
2019-11-08 15:58 ` Eric Blake [this message]
2019-11-14 21:24 ` Philippe Mathieu-Daudé
2019-11-18 19:10 ` Philippe Mathieu-Daudé
2019-11-18 19:15 ` Eric Blake
2019-11-08 14:40 ` [PATCH v2 3/3] trace: Forbid dynamic field width in event format Philippe Mathieu-Daudé
2019-11-08 16:07 ` Eric Blake
2019-11-18 18:42 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ead1eb4b-a0e0-edf9-8323-ce9f5a291547@redhat.com \
--to=eblake@redhat.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=amarkovic@wavecomp.com \
--cc=aurelien@aurel32.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).