From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com,
stefanha@redhat.com, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH v3 0/4] qcow2: async handling of fragmented io
Date: Thu, 15 Aug 2019 16:09:17 +0200 [thread overview]
Message-ID: <ed48ba6b-f90d-abe6-c77e-34c4a6bfab8c@redhat.com> (raw)
In-Reply-To: <20190815121042.121309-1-vsementsov@virtuozzo.com>
[-- Attachment #1.1: Type: text/plain, Size: 693 bytes --]
On 15.08.19 14:10, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> Here is an asynchronous scheme for handling fragmented qcow2
> reads and writes. Both qcow2 read and write functions loops through
> sequential portions of data. The series aim it to parallelize these
> loops iterations.
> It improves performance for fragmented qcow2 images, I've tested it
> as described below.
Looks good to me, but I can’t take it yet because I need to wait for
Stefan’s branch to be merged, of course.
Speaking of which, why didn’t you add any tests for the *_part()
methods? I find it a bit unsettling that nothing would have caught the
bug you had in v2 in patch 3.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-08-15 14:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 12:10 [Qemu-devel] [PATCH v3 0/4] qcow2: async handling of fragmented io Vladimir Sementsov-Ogievskiy
2019-08-15 12:10 ` [Qemu-devel] [PATCH v3 1/4] block: introduce aio task pool Vladimir Sementsov-Ogievskiy
2019-08-15 13:41 ` Max Reitz
2019-08-15 12:10 ` [Qemu-devel] [PATCH v3 2/4] block/qcow2: refactor qcow2_co_preadv_part Vladimir Sementsov-Ogievskiy
2019-08-15 13:56 ` Max Reitz
2019-08-15 12:10 ` [Qemu-devel] [PATCH v3 3/4] block/qcow2: refactor qcow2_co_pwritev_part Vladimir Sementsov-Ogievskiy
2019-08-15 14:02 ` Max Reitz
2019-08-15 12:10 ` [Qemu-devel] [PATCH v3 4/4] block/qcow2: introduce parallel subrequest handling in read and write Vladimir Sementsov-Ogievskiy
2019-08-15 14:07 ` Max Reitz
2019-08-15 13:21 ` [Qemu-devel] [PATCH v3 0/4] qcow2: async handling of fragmented io Max Reitz
2019-08-15 15:35 ` Vladimir Sementsov-Ogievskiy
2019-08-15 14:09 ` Max Reitz [this message]
2019-08-15 15:39 ` Vladimir Sementsov-Ogievskiy
2019-08-16 16:42 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed48ba6b-f90d-abe6-c77e-34c4a6bfab8c@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).