From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"John Snow" <jsnow@redhat.com>,
qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Max Reitz" <mreitz@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Miroslav Rezanina" <mrezanin@redhat.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>
Subject: Re: [PATCH 0/4] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers
Date: Wed, 28 Apr 2021 08:57:34 +0100 [thread overview]
Message-ID: <edae6f90-6658-0ad0-7516-74073d9be0c2@ilande.co.uk> (raw)
In-Reply-To: <20210415102321.3987935-1-philmd@redhat.com>
On 15/04/2021 11:23, Philippe Mathieu-Daudé wrote:
> Hi,
>
> The floppy disc controllers pulls in irrelevant devices (sysbus in
> an ISA-only machine, ISA bus + isa devices on a sysbus-only machine).
>
> This series clean that by extracting each device in its own file,
> adding the corresponding Kconfig symbols: FDC_ISA and FDC_SYSBUS.
>
> Regards,
>
> Phil.
>
> Philippe Mathieu-Daudé (4):
> hw/block/fdc: Replace disabled fprintf() by trace event
> hw/block/fdc: Declare shared prototypes in fdc-internal.h
> hw/block/fdc: Extract ISA floppy controllers to fdc-isa.c
> hw/block/fdc: Extract SysBus floppy controllers to fdc-sysbus.c
>
> hw/block/fdc-internal.h | 155 ++++++++++
> hw/block/fdc-isa.c | 313 +++++++++++++++++++++
> hw/block/fdc-sysbus.c | 252 +++++++++++++++++
> hw/block/fdc.c | 608 +---------------------------------------
> MAINTAINERS | 3 +
> hw/block/Kconfig | 8 +
> hw/block/meson.build | 2 +
> hw/block/trace-events | 3 +
> hw/i386/Kconfig | 2 +-
> hw/isa/Kconfig | 6 +-
> hw/mips/Kconfig | 2 +-
> hw/sparc/Kconfig | 2 +-
> hw/sparc64/Kconfig | 2 +-
> 13 files changed, 751 insertions(+), 607 deletions(-)
> create mode 100644 hw/block/fdc-internal.h
> create mode 100644 hw/block/fdc-isa.c
> create mode 100644 hw/block/fdc-sysbus.c
This basically looks good to me. You may be able to simplify this further by removing
the global legacy init functions fdctrl_init_sysbus() and sun4m_fdctrl_init(): from
what I can see fdctrl_init_sysbus() is only used in hw/mips/jazz.c and
sun4m_fdctrl_init() is only used in hw/sparc/sun4m.c so you might as well inline them
or move the functions to the relevant files.
Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
ATB,
Mark.
next prev parent reply other threads:[~2021-04-28 7:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 10:23 [PATCH 0/4] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers Philippe Mathieu-Daudé
2021-04-15 10:23 ` [PATCH 1/4] hw/block/fdc: Replace disabled fprintf() by trace event Philippe Mathieu-Daudé
2021-04-27 15:25 ` John Snow
2021-04-15 10:23 ` [PATCH 2/4] hw/block/fdc: Declare shared prototypes in fdc-internal.h Philippe Mathieu-Daudé
2021-04-27 16:53 ` John Snow
2021-04-27 17:56 ` Philippe Mathieu-Daudé
2021-04-15 10:23 ` [PATCH 3/4] hw/block/fdc: Extract ISA floppy controllers to fdc-isa.c Philippe Mathieu-Daudé
2021-04-27 17:11 ` John Snow
2021-04-15 10:23 ` [PATCH 4/4] hw/block/fdc: Extract SysBus floppy controllers to fdc-sysbus.c Philippe Mathieu-Daudé
2021-04-27 17:34 ` John Snow
2021-04-28 12:30 ` Philippe Mathieu-Daudé
2021-04-27 12:54 ` [PATCH 0/4] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers Philippe Mathieu-Daudé
2021-04-27 17:38 ` John Snow
2021-04-28 7:57 ` Mark Cave-Ayland [this message]
2021-04-28 11:25 ` Philippe Mathieu-Daudé
2021-04-28 12:33 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edae6f90-6658-0ad0-7516-74073d9be0c2@ilande.co.uk \
--to=mark.cave-ayland@ilande.co.uk \
--cc=aleksandar.rikalo@syrmia.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mrezanin@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).