From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA0BDC43457 for ; Fri, 16 Oct 2020 12:21:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB73521D40 for ; Fri, 16 Oct 2020 12:21:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB73521D40 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=nongnu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTOjQ-0003Lb-QL for qemu-devel@archiver.kernel.org; Fri, 16 Oct 2020 08:21:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTOhj-0002WH-3l; Fri, 16 Oct 2020 08:19:27 -0400 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]:16641) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTOhf-0006xa-RJ; Fri, 16 Oct 2020 08:19:26 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 1E7D3747624; Fri, 16 Oct 2020 14:19:17 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id F420C747623; Fri, 16 Oct 2020 14:19:16 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id F225F747622; Fri, 16 Oct 2020 14:19:16 +0200 (CEST) Date: Fri, 16 Oct 2020 14:19:16 +0200 (CEST) To: Mark Cave-Ayland Subject: Re: [PATCH v8 0/5] Mac Old World ROM experiment (ppc/mac_* clean ups and loading binary ROM) In-Reply-To: <005ed95d-65ee-ab36-c068-e96a773ef8ed@ilande.co.uk> Message-ID: References: <005ed95d-65ee-ab36-c068-e96a773ef8ed@ilande.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Received-SPF: pass client-ip=2001:738:2001:2001::2001; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: BALATON Zoltan From: BALATON Zoltan via On Fri, 16 Oct 2020, Mark Cave-Ayland wrote: > On 16/10/2020 00:47, BALATON Zoltan via wrote: >> This is the cut down version of the earlier series omitting unfinished >> patches that I plan to rework later and rebased to Mark's qemu-macppc >> branch. Compared to v7 the only change is the cast to (target_ulong) >> from (uint32_t) as requested by Mark in patch 1. > > FWIW the reason for suggesting the cast to target_ulong is so that the same > code works for both qemu-system-ppc and qemu-system-ppc64. For > qemu-system-ppc that should correctly drop the sign extension from 32-bit, > whilst still allowing someone to load a 64-bit ELF into qemu-system-ppc64 if > requested. > > Can you confirm that the sign extension behaviour is still correct for both > qemu-system-ppc and qemu-system-ppc64? If so I'm happy to give it a R-B tag. I've tried it now again with both ppc and ppc64: both OpenBIOS and a G3 beige ROM can be loaded with qemu-system-ppc but qemu-system-ppc64 fails with OpenBIOS when casting to target_ulong (i think because target_ulong is 64 bit there but g3beige is still 32 bit but I haven't throughly debugged it). But everything works with my original uint32_t cast, so ditch it and use my original version. Should I resubmit or you can fix up? (I think I wait until it's clear if this will be taken by David or you and send a fixed version cc-ing David if this is decided to go through the PPC queue.) Regards, BALATON Zoltan