From: Shivaprasad G Bhat <sbhat@linux.ibm.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, mikey@neuling.org, kvm@vger.kernel.org,
mst@redhat.com, mpe@ellerman.id.au, cohuck@redhat.com,
qemu-devel@nongnu.org, groug@kaod.org, paulus@samba.org,
clg@kaod.org, pbonzini@redhat.com, ravi.bangoria@amd.com
Subject: Re: [PATCH v5 3/3] ppc: Enable 2nd DAWR support on p10
Date: Fri, 7 Jul 2023 14:12:54 +0530 [thread overview]
Message-ID: <f9e124ca-809c-11b6-ba57-e4879d29c4b3@linux.ibm.com> (raw)
In-Reply-To: <YJIyCnVYohsdKLvf@yekko>
Hi David, All,
I am revisiting/reviving this patch.
On 5/5/21 11:20, David Gibson wrote:
> On Wed, Apr 21, 2021 at 11:50:40AM +0530, Ravi Bangoria wrote:
>> Hi David,
>>
>> On 4/19/21 10:23 AM, David Gibson wrote:
>>> On Mon, Apr 12, 2021 at 05:14:33PM +0530, Ravi Bangoria wrote:
>>>
<snip>
> Since we have released versions with POWER10 support, but no DAWR1, in
> theory we need a capability so new qemu with old machine types don't
> gain guest visible features that the same machine types on older qemus
> had.
>
> Except.. there's a loophole we might use to sidestep that. The
> current POWER10 CPU modelled in qemu is a DD1 - which I strongly
> suspect will never appear outside of IBM. I'm pretty sure we want to
> replace that with a DD2.
>
> While the modelled CPU is DD1, I think it's pretty reasonable to say
> our POWER10 support hasn't yet stabilized, and it would therefore be
> ok to simply add DAWR1 on POWER10 unconditionally, as long as we do it
> before we switch over to DD2.
As POWER10 DD2 switch over has already happened, the need for
new/separate capability for dawr1 still holds. So, I am keeping it as is.
Posting the next version after rebase.
Thanks,
Shivaprasad
>>> I'm wondering if we're actually just better off setting the pa feature
>>> just based on the guest CPU model. TCG will be broken if you try to
>>> use it, but then, it already is. AFAIK there's no inherent reason we
>>> couldn't implement DAWR support in TCG, it's just never been worth the
>>> trouble.
>> Correct. Probably there is no practical usecase for DAWR in TCG mode.
>>
>> Thanks,
>> Ravi
>>
prev parent reply other threads:[~2023-07-07 8:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 11:44 [PATCH v5 0/3] ppc: Enable 2nd DAWR support on Power10 Ravi Bangoria
2021-04-12 11:44 ` [PATCH v5 1/3] Linux headers: update from 5.12-rc3 Ravi Bangoria
2021-04-12 11:44 ` [PATCH v5 2/3] ppc: Rename current DAWR macros and variables Ravi Bangoria
2021-04-19 4:47 ` David Gibson
2021-04-12 11:44 ` [PATCH v5 3/3] ppc: Enable 2nd DAWR support on p10 Ravi Bangoria
2021-04-12 13:10 ` Cédric Le Goater
2021-04-19 4:53 ` David Gibson
2021-04-21 6:20 ` Ravi Bangoria
2021-04-21 6:31 ` Cédric Le Goater
2021-04-21 6:54 ` Ravi Bangoria
2021-04-22 1:56 ` David Gibson
2021-04-22 4:45 ` Richard Henderson
2021-05-05 5:50 ` David Gibson
2023-07-07 8:42 ` Shivaprasad G Bhat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9e124ca-809c-11b6-ba57-e4879d29c4b3@linux.ibm.com \
--to=sbhat@linux.ibm.com \
--cc=YJIyCnVYohsdKLvf@yekko.fra02v.mail.ibm.com \
--cc=clg@kaod.org \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=kvm@vger.kernel.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=paulus@samba.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=ravi.bangoria@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).