From: "Kővágó, Zoltán" <dirty.ice.hu@gmail.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH v2 20/24] audio: basic support for multichannel audio
Date: Sun, 8 Sep 2019 23:22:20 +0200 [thread overview]
Message-ID: <fbc093cea392d1b05489030f817a74fe68a046b0.1567965065.git.DirtY.iCE.hu@gmail.com> (raw)
In-Reply-To: <cover.1567965065.git.DirtY.iCE.hu@gmail.com>
Which currently only means removing some checks. Old code won't require
more than two channels, but new code will need it.
Signed-off-by: Kővágó, Zoltán <DirtY.iCE.hu@gmail.com>
---
audio/alsaaudio.c | 7 -------
audio/audio.c | 2 +-
2 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c
index eddf013a53..f37ce1ce85 100644
--- a/audio/alsaaudio.c
+++ b/audio/alsaaudio.c
@@ -493,13 +493,6 @@ static int alsa_open(bool in, struct alsa_params_req *req,
goto err;
}
- if (nchannels != 1 && nchannels != 2) {
- alsa_logerr2 (err, typ,
- "Can not handle obtained number of channels %d\n",
- nchannels);
- goto err;
- }
-
if (apdo->buffer_length) {
int dir = 0;
unsigned int btime = apdo->buffer_length;
diff --git a/audio/audio.c b/audio/audio.c
index 7821365a85..6a5979f262 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -242,7 +242,7 @@ static int audio_validate_settings (struct audsettings *as)
{
int invalid;
- invalid = as->nchannels != 1 && as->nchannels != 2;
+ invalid = as->nchannels < 1;
invalid |= as->endianness != 0 && as->endianness != 1;
switch (as->fmt) {
--
2.23.0
next prev parent reply other threads:[~2019-09-08 21:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-08 21:22 [Qemu-devel] [PATCH v2 00/24] Audio: Mixeng-free 5.1/7.1 audio support Kővágó, Zoltán
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 01/24] audio: api for mixeng code free backends Kővágó, Zoltán
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 02/24] alsaaudio: port to the new audio backend api Kővágó, Zoltán
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 03/24] coreaudio: " Kővágó, Zoltán
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 04/24] dsoundaudio: " Kővágó, Zoltán
2019-09-11 7:00 ` Gerd Hoffmann
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 05/24] noaudio: " Kővágó, Zoltán
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 06/24] ossaudio: " Kővágó, Zoltán
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 07/24] paaudio: " Kővágó, Zoltán
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 08/24] sdlaudio: " Kővágó, Zoltán
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 10/24] wavaudio: " Kővágó, Zoltán
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 11/24] audio: remove remains of the old " Kővágó, Zoltán
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 12/24] audio: unify input and output mixeng buffer management Kővágó, Zoltán
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 13/24] audio: common rate control code for timer based outputs Kővágó, Zoltán
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 14/24] audio: split ctl_* functions into enable_* and volume_* Kővágó, Zoltán
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 15/24] audio: add mixeng option (documentation) Kővágó, Zoltán
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 16/24] audio: make mixeng optional Kővágó, Zoltán
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 18/24] audio: support more than two channels in volume setting Kővágó, Zoltán
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 19/24] audio: replace shift in audio_pcm_info with bytes_per_frame Kővágó, Zoltán
2019-09-08 21:22 ` Kővágó, Zoltán [this message]
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 21/24] paaudio: channel-map option Kővágó, Zoltán
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 22/24] usb-audio: do not count on avail bytes actually available Kővágó, Zoltán
2019-09-08 21:22 ` [Qemu-devel] [PATCH v2 24/24] usbaudio: change playback counters to 64 bit Kővágó, Zoltán
2019-09-12 10:20 ` [Qemu-devel] [PATCH v2 00/24] Audio: Mixeng-free 5.1/7.1 audio support Gerd Hoffmann
2019-09-15 1:08 ` Zoltán Kővágó
2019-09-17 11:38 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbc093cea392d1b05489030f817a74fe68a046b0.1567965065.git.DirtY.iCE.hu@gmail.com \
--to=dirty.ice.hu@gmail.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).