From: Jason Wang <jasowang@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v3 0/2] net: Drop legacy "name" from -net and remove NetLegacy
Date: Tue, 16 Jun 2020 14:26:44 +0800 [thread overview]
Message-ID: <ff5d1188-3b67-fc3f-fa47-77f5435f34bf@redhat.com> (raw)
In-Reply-To: <ccb94bbf-62f8-a15c-c7ba-5d2da724757f@redhat.com>
On 2020/6/15 下午8:06, Thomas Huth wrote:
> On 18/05/2020 20.01, Thomas Huth wrote:
>> Since commit b4983c570c7a ("net: Remove deprecated [hub_id name] tuple of
>> 'hostfwd_add' / 'hostfwd_remove'"), the "name" parameter is not used
>> internally anymore. And it's been marked as deprecated since QEMU v3.1,
>> so it is time to remove the "name" parameter from -net now. Once this
>> has been done, we can also drop the obsolete NetLegacy structure since
>> there is no major difference between Netdev and NetLegacy anymore.
>>
>> v3:
>> - Do not make "id" in Netdev optional, but rather assign a temporary
>> "id" for -net before we call the options visitor function.
>> - Changed some "void *" to "Netdev *" now
>>
>> v2:
>> - Rebased to master (use the deprecated.rst instead of qemu-deprecated.texi)
>>
>> Thomas Huth (2):
>> net: Drop the legacy "name" parameter from the -net option
>> net: Drop the NetLegacy structure, always use Netdev instead
> Ping!
>
> Jason, do you think these patches are OK now, and if so, could you
> please queue them for your next net pull request?
Queued.
Sorry for the late.
Thanks
>
> Thanks,
> Thomas
>
>
prev parent reply other threads:[~2020-06-16 6:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 18:01 [PATCH v3 0/2] net: Drop legacy "name" from -net and remove NetLegacy Thomas Huth
2020-05-18 18:01 ` [PATCH v3 1/2] net: Drop the legacy "name" parameter from the -net option Thomas Huth
2020-05-18 18:01 ` [PATCH v3 2/2] net: Drop the NetLegacy structure, always use Netdev instead Thomas Huth
2020-05-21 21:51 ` Eric Blake
2020-06-15 12:06 ` [PATCH v3 0/2] net: Drop legacy "name" from -net and remove NetLegacy Thomas Huth
2020-06-16 6:26 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff5d1188-3b67-fc3f-fa47-77f5435f34bf@redhat.com \
--to=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).