qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vincent Bernat <vincent@bernat.ch>
To: Igor Mammedov <imammedo@redhat.com>
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
	qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v3] hw/smbios: support for type 41 (onboard devices extended information)
Date: Tue, 06 Apr 2021 21:12:04 +0200	[thread overview]
Message-ID: <m3zgyb9qij.fsf@bernat.ch> (raw)
In-Reply-To: <20210406210558.15749f84@redhat.com> (Igor Mammedov's message of "Tue, 6 Apr 2021 21:05:58 +0200")

 ❦  6 avril 2021 21:05 +02, Igor Mammedov:

>> >>> This can be invoked with:
>> >>> 
>> >>>     $QEMU -netdev user,id=internet
>> >>>           -device virtio-net-pci,mac=50:54:00:00:00:42,netdev=internet,id=internet-dev \
>> >>>           -smbios type=41,designation='Onboard LAN',instance=1,kind=ethernet,pcidev=internet-dev  
>> >>
>> >> an ACPI alternative was merged recently (current master).
>> >> assigning 'designation=' wasn't implemented there, but important part
>> >> of giving users control over PCI devices 'eno' index is implemented.
>> >>
>> >> When I looked into the issue, smbios way was a bit over-kill for the task
>> >> and didn't really work if hotplug were used.
>> >>
>> >> See, for example how to use new feature:
>> >>  https://www.mail-archive.com/qemu-devel@nongnu.org/msg794164.html  
>> >
>> > It seems simpler this way. I don't think my patch is needed then.  
>> 
>> Well, after thinking a bit, if the patch is good enough, maybe it can
>> still be merged. It is fairly generic and it adds the ability to set the
>> name of the card. It's not as convenient as using acpi-index, but I
>> could add a note about acpi-index in the documentation to let people
>> know they may prefer the simpler acpi-index?
>
> Patch looks fine to me.
> Can you fix TODO item in it (segment_group_number) on next respin,
> pls?

I think this is already done in the v4 posted a few days ago:

https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg00238.html
-- 
There is a great discovery still to be made in Literature: that of
paying literary men by the quantity they do NOT write.


  reply	other threads:[~2021-04-06 19:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01 12:26 [PATCH v3] hw/smbios: support for type 41 (onboard devices extended information) Vincent Bernat
2021-04-01 20:58 ` Igor Mammedov
2021-04-01 21:07   ` Vincent Bernat
2021-04-01 21:32     ` Igor Mammedov
2021-04-06  7:42       ` Andrew Jones
2021-04-06 18:36         ` Igor Mammedov
2021-04-06 19:02           ` Andrew Jones
2021-04-02 17:40     ` Vincent Bernat
2021-04-06 19:05       ` Igor Mammedov
2021-04-06 19:12         ` Vincent Bernat [this message]
2021-04-07 13:33         ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3zgyb9qij.fsf@bernat.ch \
    --to=vincent@bernat.ch \
    --cc=berrange@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).