From: Marc Kleine-Budde <mkl@pengutronix.de>
To: linux-can@vger.kernel.org
Cc: kernel@pengutronix.de, Dan Murphy <dmurphy@ti.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [net-rfc 09/12] can: m_can: tcan4x5x: tcan4x5x_can_remove(): fix order of deregistration
Date: Mon, 19 Oct 2020 17:42:30 +0200 [thread overview]
Message-ID: <20201019154233.1262589-10-mkl@pengutronix.de> (raw)
In-Reply-To: <20201019154233.1262589-1-mkl@pengutronix.de>
Change the order in tcan4x5x_can_remove() to be the exact inverse of
tcan4x5x_can_probe(). First m_can_class_unregister(), then power down the
device.
Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel")
Cc: Dan Murphy <dmurphy@ti.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/m_can/tcan4x5x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/can/m_can/tcan4x5x.c b/drivers/net/can/m_can/tcan4x5x.c
index 2fcbcd1b89b7..a2144bbcd486 100644
--- a/drivers/net/can/m_can/tcan4x5x.c
+++ b/drivers/net/can/m_can/tcan4x5x.c
@@ -531,10 +531,10 @@ static int tcan4x5x_can_remove(struct spi_device *spi)
{
struct tcan4x5x_priv *priv = spi_get_drvdata(spi);
- tcan4x5x_power_enable(priv->power, 0);
-
m_can_class_unregister(priv->mcan_dev);
+ tcan4x5x_power_enable(priv->power, 0);
+
m_can_class_free_dev(priv->mcan_dev->net);
return 0;
--
2.28.0
next prev parent reply other threads:[~2020-10-19 15:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 15:42 [RFC]: can 2020-10-19: m_can/tcan4x5x Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 01/12] can: m_can: remove double clearing of clock stop request bit Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 02/12] can: m_can: m_can_handle_state_change(): fix state change Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 03/12] can: tcan4x5x: replace depends on REGMAP_SPI with depends on SPI Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 04/12] can: tcan4x5x: tcan4x5x_clear_interrupts(): remove redundant return statement Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 05/12] can: tcan4x5x: Rename parse_config() function Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 06/12] can: tcan4x5x: tcan4x5x_can_probe(): add missing error checking for devm_regmap_init() Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 07/12] can: m_can: m_can_class_free_dev(): introduce new function Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 08/12] can: m_can: Fix freeing of can device from peripherials Marc Kleine-Budde
2020-10-19 15:42 ` Marc Kleine-Budde [this message]
2020-10-19 15:42 ` [net-rfc 10/12] can: tcan4x5x: Move clock init to TCAN driver Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 11/12] can: m_can_platform: Move clock discovery and init to platform Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 12/12] can: m_can: Remove unused clock function from the framework Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019154233.1262589-10-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=dmurphy@ti.com \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.