From: Steven Rostedt <rostedt@goodmis.org>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com,
keescook@chromium.org, mathieu.desnoyers@efficios.com,
Jessica Yu <jeyu@kernel.org>,
kernel-hardening@lists.openwall.com, kernel-team@android.com,
rcu@vger.kernel.org
Subject: Re: [PATCH v3 3/3] module: Make __tracepoints_ptrs as read-only
Date: Wed, 10 Apr 2019 20:44:01 -0400 [thread overview]
Message-ID: <20190410204401.62f928ca@gandalf.local.home> (raw)
In-Reply-To: <20190410202902.GA167446@google.com>
On Wed, 10 Apr 2019 16:29:02 -0400
Joel Fernandes <joel@joelfernandes.org> wrote:
> The srcu structure pointer array is modified at module load time because the
> array is fixed up by the module loader at load-time with the final locations
> of the tracepoints right? Basically relocation fixups. At compile time, I
> believe it is not know what the values in the ptr array are. I believe same
> is true for the tracepoint ptrs array.
>
> Also it needs to be in a separate __tracepoint_ptrs so that this code works:
>
>
> #ifdef CONFIG_TRACEPOINTS
> mod->tracepoints_ptrs = section_objs(info, "__tracepoints_ptrs",
> sizeof(*mod->tracepoints_ptrs),
> &mod->num_tracepoints);
> #endif
>
> Did I miss some point? Thanks,
But there's a lot of others too. Hmm, does this mean that the RO data
sections that are in modules are not set to RO?
There's a bunch of separate sections that are RO. Just look in
include/asm-generic/vmlinux.lds.h under the RO_DATA_SECTION() macro.
A lot of the sections saved in module.c:find_module_sections() are in
that RO_DATA when compiled as a builtin. Are they not RO when loaded via
a module?
If this is the case, there probably is going to be a lot more sections
added to your list.
-- Steve
next prev parent reply other threads:[~2019-04-11 0:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 19:57 [PATCH v3 1/3] module: Prepare for addition of new ro_after_init sections Joel Fernandes (Google)
2019-04-10 19:57 ` [PATCH v3 2/3] module: Make srcu_struct ptr array as read-only post init Joel Fernandes (Google)
2019-04-10 19:57 ` [PATCH v3 3/3] module: Make __tracepoints_ptrs as read-only Joel Fernandes (Google)
2019-04-10 20:11 ` Steven Rostedt
2019-04-10 20:29 ` Joel Fernandes
2019-04-11 0:44 ` Steven Rostedt [this message]
2019-04-11 8:21 ` Joel Fernandes
2019-04-11 13:19 ` Steven Rostedt
2019-04-11 20:06 ` Joel Fernandes
2019-04-11 13:44 ` Paul E. McKenney
2019-04-17 15:16 ` Jessica Yu
2019-04-17 15:36 ` Paul E. McKenney
2019-04-20 11:38 ` Joel Fernandes
2019-04-11 8:32 ` [PATCH v3 1/3] module: Prepare for addition of new ro_after_init sections Miroslav Benes
2019-04-17 13:29 ` Jessica Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410204401.62f928ca@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=jeyu@kernel.org \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).