From: Frederic Weisbecker <frederic@kernel.org>
To: "Paul E. McKenney" <paulmck@linux.ibm.com>
Cc: Joel Fernandes <joel@joelfernandes.org>, rcu@vger.kernel.org
Subject: Re: need_heavy_qs flag for PREEMPT=y kernels
Date: Mon, 19 Aug 2019 18:57:10 +0200 [thread overview]
Message-ID: <20190819165710.GF27088@lenoir> (raw)
In-Reply-To: <20190815203107.GL28441@linux.ibm.com>
On Thu, Aug 15, 2019 at 01:31:07PM -0700, Paul E. McKenney wrote:
> On Thu, Aug 15, 2019 at 04:04:32PM -0400, Joel Fernandes wrote:
> > diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
> > index be9707f68024..e697c7a2ce67 100644
> > --- a/kernel/time/tick-sched.c
> > +++ b/kernel/time/tick-sched.c
> > @@ -198,6 +198,10 @@ static bool check_tick_dependency(atomic_t *dep)
> > return true;
> > }
> >
> > + if (val & TICK_DEP_MASK_CLOCK_RCU) {
> > + return true;
> > + }
> > +
> > return false;
> > }
>
> That one is not in my tree, either. Frederic, should I add this to
> your patch? For that matter, may I add your Signed-off-by as well?
> Your original is in my -rcu tree at:
>
> 0cb41806c799 ("EXP nohz: Add TICK_DEP_BIT_RCU")
>
> I am testing Joel's suggested addition now.
Also this:
diff --git a/include/trace/events/timer.h b/include/trace/events/timer.h
index b7a904825e7d..295517f109d7 100644
--- a/include/trace/events/timer.h
+++ b/include/trace/events/timer.h
@@ -367,7 +367,8 @@ TRACE_EVENT(itimer_expire,
tick_dep_name(POSIX_TIMER) \
tick_dep_name(PERF_EVENTS) \
tick_dep_name(SCHED) \
- tick_dep_name_end(CLOCK_UNSTABLE)
+ tick_dep_name(CLOCK_UNSTABLE) \
+ tick_dep_name_end(RCU)
#undef tick_dep_name
#undef tick_dep_mask_name
next prev parent reply other threads:[~2019-08-19 16:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-11 18:08 need_heavy_qs flag for PREEMPT=y kernels Joel Fernandes
2019-08-11 18:34 ` Joel Fernandes
2019-08-11 21:16 ` Paul E. McKenney
2019-08-11 21:25 ` Joel Fernandes
2019-08-11 23:30 ` Paul E. McKenney
2019-08-12 1:24 ` Joel Fernandes
2019-08-12 1:40 ` Joel Fernandes
2019-08-12 3:57 ` Paul E. McKenney
2019-08-11 21:13 ` Paul E. McKenney
2019-08-12 3:21 ` Joel Fernandes
2019-08-12 3:53 ` Paul E. McKenney
2019-08-12 21:20 ` Joel Fernandes
2019-08-12 23:01 ` Paul E. McKenney
2019-08-13 1:02 ` Joel Fernandes
2019-08-13 1:05 ` Joel Fernandes
2019-08-13 2:28 ` Paul E. McKenney
2019-08-13 2:27 ` Paul E. McKenney
2019-08-13 2:50 ` Paul E. McKenney
2019-08-15 17:17 ` Paul E. McKenney
2019-08-15 20:04 ` Joel Fernandes
2019-08-15 20:31 ` Paul E. McKenney
2019-08-15 21:22 ` Joel Fernandes
2019-08-15 21:27 ` Joel Fernandes
2019-08-15 21:34 ` Joel Fernandes
2019-08-15 21:57 ` Paul E. McKenney
2019-08-15 21:45 ` Paul E. McKenney
2019-08-16 0:02 ` Joel Fernandes
2019-08-19 12:34 ` Frederic Weisbecker
2019-08-19 12:09 ` Frederic Weisbecker
2019-08-19 16:57 ` Frederic Weisbecker [this message]
2019-08-19 22:31 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819165710.GF27088@lenoir \
--to=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=paulmck@linux.ibm.com \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).