From: "Paul E. McKenney" <paulmck@kernel.org>
To: "Joel Fernandes (Google)" <joel@joelfernandes.org>
Cc: linux-kernel@vger.kernel.org,
Josh Triplett <josh@joshtriplett.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Neeraj Upadhyay <neeraju@codeaurora.org>,
rcu@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v2 3/3] rcu/tree: Make FQS complaining about offline CPU more aggressive
Date: Thu, 30 Jul 2020 18:36:07 -0700 [thread overview]
Message-ID: <20200731013607.GH9247@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20200731004012.2324147-3-joel@joelfernandes.org>
On Thu, Jul 30, 2020 at 08:40:12PM -0400, Joel Fernandes (Google) wrote:
> Make FQS loop consider it an immediate failure if the case of an offline CPU
> reporting QS is detected, instead of a full second.
>
> This is because rcu_report_dead() already reports quiescent states and
> updates ->qsmaskinitnext under node lock.
>
> Light testing with TREE03 and hotplug shows no warnings.
>
> Convert the warning as well to WARN_ON_ONCE() to reduce log spam.
I will give you a chance to upgrade the above on your V3.
And the comment below.
I do very much like the change to WARN_ON_ONCE(), by the way!
Thanx, Paul
> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> ---
> kernel/rcu/tree.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index a621932cc385..39bdd744ba97 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -1208,13 +1208,15 @@ static int rcu_implicit_dynticks_qs(struct rcu_data *rdp)
> return 1;
> }
>
> - /* If waiting too long on an offline CPU, complain. */
> - if (!(rdp->grpmask & rcu_rnp_online_cpus(rnp)) &&
> - time_after(jiffies, rcu_state.gp_start + HZ)) {
> + /*
> + * Complain if an offline CPU by RCU's books has not reported QS. Node
> + * lock is held ensuring offlining does not race here.
> + */
> + if (!(rdp->grpmask & rcu_rnp_online_cpus(rnp))) {
> bool onl;
> struct rcu_node *rnp1;
>
> - WARN_ON(1); /* Offline CPUs are supposed to report QS! */
> + WARN_ON_ONCE(1); /* Offline CPUs are supposed to report QS! */
> pr_info("%s: grp: %d-%d level: %d ->gp_seq %ld ->completedqs %ld\n",
> __func__, rnp->grplo, rnp->grphi, rnp->level,
> (long)rnp->gp_seq, (long)rnp->completedqs);
> --
> 2.28.0.163.g6104cc2f0b6-goog
>
prev parent reply other threads:[~2020-07-31 1:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 0:40 [PATCH v2 1/3] rcu/tree: Add a warning if CPU being onlined did not report QS already Joel Fernandes (Google)
2020-07-31 0:40 ` [PATCH v2 2/3] rcu/tree: Clarify comments about FQS loop reporting quiescent states Joel Fernandes (Google)
2020-07-31 0:40 ` [PATCH v2 3/3] rcu/tree: Make FQS complaining about offline CPU more aggressive Joel Fernandes (Google)
2020-07-31 1:36 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731013607.GH9247@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=neeraju@codeaurora.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).