From: Orlando Chamberlain <redecorating@protonmail.com>
To: Keith Busch <kbusch@kernel.org>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
"gargaditya08@live.com" <gargaditya08@live.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"hare@suse.de" <hare@suse.de>,
"dwagner@suse.de" <dwagner@suse.de>, "hch@lst.de" <hch@lst.de>
Subject: Re: [REGRESSION] nvme: code command_id with a genctr for use-after-free validation crashes apple T2 SSD
Date: Sun, 26 Sep 2021 04:35:30 +0000 [thread overview]
Message-ID: <1b5d6bef-db6f-073f-8d24-4963f0df82ab@protonmail.com> (raw)
In-Reply-To: <1a6f5030-27d9-d1ae-aff4-0ed2a10dce6b@protonmail.com>
On 26/9/21 13:53, Orlando Chamberlain wrote:
>> Great, that's essentially what I proposed in a different thread (sorry, I see
>> now you were not copied there):
>>
>> http://lists.infradead.org/pipermail/linux-nvme/2021-September/027665.html
>>
>> The final patch may look a bit different, but it should be okay to test with
>> the one in the link.
>>
> I've tried that patch, it doesn't crash, but /dev/nvme0, /dev/nvme0n1 etc don't show up so
> it doesn't progress past the initramfs. There weren't any errors other than preexisting
> acpi table ones.
>
The issue was that there's a , instead of a | at the end of the second line here. It works when that is replaced with a |.
- NVME_QUIRK_SHARED_TAGS },
+ NVME_QUIRK_SHARED_TAGS ,
+ NVME_QUIRK_SKIP_CID_GEN },
next prev parent reply other threads:[~2021-09-26 4:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 13:10 [REGRESSION] nvme: code command_id with a genctr for use-after-free validation crashes apple T2 SSD Orlando Chamberlain
2021-09-25 17:16 ` Keith Busch
2021-09-25 23:40 ` Orlando Chamberlain
2021-09-26 2:08 ` Keith Busch
2021-09-26 3:53 ` Orlando Chamberlain
2021-09-26 4:35 ` Orlando Chamberlain [this message]
[not found] ` <PNZPR01MB4415801C6084E8CFD068A84AB8A69@PNZPR01MB4415.INDPRD01.PROD.OUTLOOK.COM>
2021-09-26 8:44 ` Sagi Grimberg
2021-09-27 4:22 ` Orlando Chamberlain
2021-09-27 4:51 ` Aditya Garg
2021-09-27 6:05 ` Sven Peter
2021-09-27 15:02 ` Keith Busch
2021-09-26 5:59 ` Thorsten Leemhuis
2021-10-04 9:17 ` Thorsten Leemhuis
2021-10-04 9:27 ` Greg KH
2021-10-04 10:11 ` Thorsten Leemhuis
2021-10-04 11:36 ` Greg KH
2021-10-05 5:50 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b5d6bef-db6f-073f-8d24-4963f0df82ab@protonmail.com \
--to=redecorating@protonmail.com \
--cc=dwagner@suse.de \
--cc=gargaditya08@live.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=regressions@lists.linux.dev \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).