From: Kalle Valo <kvalo@codeaurora.org>
To: "Stanisław Gruszka" <stf_xl@wp.pl>
Cc: Exuvo <exuvo@exuvo.se>,
Thorsten Leemhuis <regressions@leemhuis.info>,
Stanislaw Gruszka <sgruszka@redhat.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
Helmut Schaa <helmut.schaa@googlemail.com>,
"regressions\@lists.linux.dev" <regressions@lists.linux.dev>
Subject: Re: rt2x00 regression
Date: Wed, 10 Nov 2021 08:59:22 +0200 [thread overview]
Message-ID: <87wnlgo5rp.fsf@codeaurora.org> (raw)
In-Reply-To: <cc85b4e8a038417b865069c6578acf50@grupawp.pl> (=?utf-8?Q?=22S?= =?utf-8?Q?tanis=C5=82aw?= Gruszka"'s message of "Tue, 09 Nov 2021 18:36:08 +0100")
Stanisław Gruszka <stf_xl@wp.pl> writes:
> Dnia 9 listopada 2021 16:22 Exuvo <exuvo@exuvo.se> napisał(a):
>
> Just tested it and it passes the rt2x00lib_load_firmware but still errors on
> rt2800usb_set_device_state:
>
> <snip>
>
> @@ -30,7 +30,8 @@ static bool rt2x00usb_check_usb_error(struct rt2x00_dev *rt2x00dev, int status)
> else
> rt2x00dev->num_proto_errs = 0;
>
> - if (rt2x00dev->num_proto_errs > 3)
> + if (rt2x00dev->num_proto_errs > 3 &&
> + !test_bit(DEVICE_STATE_STARTED, &rt2x00dev->flags))
> return true;
>
> return false;
>
> Sorry, I screwed logic in my patch. It should be test_bit() instead of !test_bit().
> And also we should not count when device did not start. So patch should be somewhat different. I'll
> send tomorrow hopefully better patch.
No HTML, please :) I'll reply so that lists see your email.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-11-10 6:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bff7d309-a816-6a75-51b6-5928ef4f7a8c@exuvo.se>
[not found] ` <20190927080303.GA7667@redhat.com>
[not found] ` <CA+GwT0B5SyRZnGLqwqOeuJK4CWMVc=dKaWre9VN8KQC6kBzKGw@mail.gmail.com>
[not found] ` <20191203075736.GA701@redhat.com>
[not found] ` <d74dab51-3a84-9035-d89e-ea8f63e89198@exuvo.se>
[not found] ` <a8eeb0bc-95da-291a-7fb9-5d15d1174c27@exuvo.se>
[not found] ` <c22673af-40e0-3af2-5ab7-69b23fc03598@exuvo.se>
[not found] ` <f935dc15-08bd-2e28-fc1b-b27634c618be@exuvo.se>
2021-10-01 6:56 ` rt2x00 regression Kalle Valo
2021-10-01 8:24 ` Thorsten Leemhuis
2021-11-30 9:16 ` rt2x00 regression #forregzbot Thorsten Leemhuis
2021-11-05 13:25 ` rt2x00 regression Thorsten Leemhuis
2021-11-08 18:00 ` Thorsten Leemhuis
[not found] ` <20211109073127.ga109212@wp.pl>
2021-11-09 7:31 ` Stanislaw Gruszka
2021-11-09 12:07 ` Stanislaw Gruszka
2021-11-09 15:22 ` Exuvo
[not found] ` <cc85b4e8a038417b865069c6578acf50@grupawp.pl>
2021-11-10 6:59 ` Kalle Valo [this message]
2021-11-10 8:01 ` Stanislaw Gruszka
2021-11-11 10:54 ` Exuvo
2021-11-11 14:10 ` [PATCH] rt2x00: do not mark device gone on EPROTO errors during start Stanislaw Gruszka
2021-11-18 6:16 ` Thorsten Leemhuis
2021-11-19 14:19 ` Kalle Valo
2021-11-29 10:54 ` Kalle Valo
[not found] <ca+gwt0b5syrznglqwqoeujk4cwmvc=dkawre9vn8kqc6kbzkgw@mail.gmail.com>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnlgo5rp.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=exuvo@exuvo.se \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=sgruszka@redhat.com \
--cc=stf_xl@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).