From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BA3170 for ; Thu, 20 May 2021 18:17:34 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 8C7DA60C3E; Thu, 20 May 2021 18:17:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621534654; bh=wYrdjMb4Si9p5I1W2PD9OycnsQPlep2BsLRz4L9qzk8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BEYcKjfkk+oR+MUFf08Rl1U+1Vep+4KR+08EfCBK7fna6RK7jkwhPKm4WOG3/HHAa eSwyEpc84AWXG76ds0dOffOPi7CCRK9ejkr3QCFytr8L2WaQ+ccIa2bnEQB1ZXH83D S3z1K3m1aPYRVbYilFtHxfNdJCTNr5soJVbJw8gE= Date: Thu, 20 May 2021 20:17:31 +0200 From: Greg KH To: Bhaumik Bhatt Cc: Kalle Valo , Manivannan Sadhasivam , Loic Poulain , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, regressions@lists.linux.dev, stable@vger.kernel.org Subject: Re: [regressions] ath11k: v5.12.3 mhi regression Message-ID: References: <87v97dhh2u.fsf@codeaurora.org> <20210520104313.GA128703@thinkpad> <87r1i1h9an.fsf@codeaurora.org> <3e8bac3b02e3549a55b7c9b78b699965@codeaurora.org> <608474b9b9feae5bd0616ad16d6d6bbd@codeaurora.org> X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <608474b9b9feae5bd0616ad16d6d6bbd@codeaurora.org> On Thu, May 20, 2021 at 11:04:05AM -0700, Bhaumik Bhatt wrote: > On 2021-05-20 10:58 AM, Greg KH wrote: > > On Thu, May 20, 2021 at 10:38:12AM -0700, Bhaumik Bhatt wrote: > > > On 2021-05-20 05:36 AM, Kalle Valo wrote: > > > > Manivannan Sadhasivam writes: > > > > > > > > > On Thu, May 20, 2021 at 12:02:40PM +0200, Greg KH wrote: > > > > > > On Thu, May 20, 2021 at 12:47:53PM +0300, Kalle Valo wrote: > > > > > > > Hi, > > > > > > > > > > > > > > I got several reports that this mhi commit broke ath11k in v5.12.3: > > > > > > > > > > > > > > commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed > > > > > > > Author: Bhaumik Bhatt > > > > > > > Date: Wed Feb 24 15:23:04 2021 -0800 > > > > > > > > > > > > > > bus: mhi: core: Process execution environment changes serially > > > > > > > > > > > > > > [ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ] > > > > > > > > > > > > > > Here are the reports: > > > > > > > > > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=213055 > > > > > > > > > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=212187 > > > > > > > > > > > > > > https://bugs.archlinux.org/task/70849?project=1&string=linux > > > > > > > > > > > > > > Interestingly v5.13-rc1 seems to work fine, at least for me, though I > > > > > > > have not tested v5.12.3 myself. Can someone revert this commit in the > > > > > > > stable release so that people get their wifi working again, please? > > > > > > > > > > > > How does the mhi bus code relate to a ath11k driver? What bus > > > > > > is that > > > > > > on? > > > > > > > > > > > > > > > > MHI is the transport used by the ath11k driver to work with the WLAN > > > > > devices > > > > > over PCIe. > > > > > > > > > > Regarding the bug, I'd suggest to wait for Bhaumik (the author of > > > > > 29b9829718c5) > > > > > to comment on the possible commit which needs backporting from > > > > > mainline. > > > > > > > > Ok, but if a quick fix is not available I think we should just revert > > > > this in the stable releases. I also got a report that v5.11.21 is > > > > broken: > > > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=213055#c11 > > > > > > Please pick [1] as the dependency to [ Upstream commit > > > ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]. > > > > what is [1]??? > > > > What commit do I need to backport, a commit id would be nice... > > > > thanks, > > > > greg k-h > Sure Greg. Commit id is: 4884362f6977fc05cbec736625665241c0e0732f > > Title of patch: > bus: mhi: core: Download AMSS image from appropriate function > > It was supposed to be a link but not sure why it's not seen. Text email doesn't have links :) Anyway, thanks, now queued up. Also note, it's nice to write kernel commit ids as 4884362f6977 ("bus: mhi: core: Download AMSS image from appropriate function") which is the preferred way to reference them in a emails and commit logs. thanks, greg k-h