From: Alice Ryhl <aliceryhl@google.com>
To: gary@garyguo.net
Cc: a.hindborg@samsung.com, alex.gaynor@gmail.com,
aliceryhl@google.com, benno.lossin@proton.me,
bjorn3_gh@protonmail.com, boqun.feng@gmail.com,
linux-kernel@vger.kernel.org, ojeda@kernel.org,
rust-for-linux@vger.kernel.org, wedsonaf@gmail.com
Subject: Re: [PATCH] rust: macros: add `paste!` proc macro
Date: Mon, 3 Jul 2023 11:37:07 +0000 [thread overview]
Message-ID: <20230703113708.1758734-1-aliceryhl@google.com> (raw)
In-Reply-To: <20230628171108.1150742-1-gary@garyguo.net>
Gary Guo <gary@garyguo.net> writes:
> This macro provides a flexible way to concatenated identifiers together
> and it allows the resulting identifier to be used to declare new items,
> which `concat_idents!` does not allow. It also allows identifiers to be
> transformed before concatenated.
>
> The `concat_idents!` example
>
> let x_1 = 42;
> let x_2 = concat_idents!(x, _1);
> assert!(x_1 == x_2);
>
> can be written with `paste!` macro like this:
>
> let x_1 = 42;
> let x_2 = paste!([<x _1>]);
> assert!(x_1 == x_2);
>
> However `paste!` macro is more flexible because it can be used to create
> a new variable:
>
> let x_1 = 42;
> paste!(let [<x _2>] = [<x _1>];);
> assert!(x_1 == x_2);
>
> While this is not possible with `concat_idents!`.
>
> This macro is similar to the `paste!` crate [1], but this is a fresh
> implementation to avoid vendoring large amount of code directly. Also, I
> have augmented it to provide a way to specify span of the resulting
> token, allowing precise control.
>
> For example, this code is broken because the variable is declared inside
> the macro, so Rust macro hygiene rules prevents access from the outside:
>
> macro_rules! m {
> ($id: ident) => {
> // The resulting token has hygiene of the macro.
> paste!(let [<$id>] = 1;)
> }
> }
>
> m!(a);
> let _ = a;
>
> In this versionn of `paste!` macro I added a `span` modifier to allow
> this:
>
> macro_rules! m {
> ($id: ident) => {
> // The resulting token has hygiene of `$id`.
> paste!(let [<$id:span>] = 1;)
> }
> }
>
> m!(a);
> let _ = a;
>
> Link: http://docs.rs/paste/ [1]
> Signed-off-by: Gary Guo <gary@garyguo.net>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
next prev parent reply other threads:[~2023-07-03 11:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 17:11 [PATCH] rust: macros: add `paste!` proc macro Gary Guo
2023-06-28 19:00 ` Benno Lossin
2023-06-28 19:03 ` Björn Roy Baron
2023-06-29 0:51 ` Martin Rodriguez Reboredo
2023-07-03 11:37 ` Alice Ryhl [this message]
2023-08-09 21:45 ` Miguel Ojeda
2023-08-09 22:02 ` Gary Guo
2023-08-09 22:29 ` Miguel Ojeda
2023-08-10 5:08 ` Greg KH
2023-08-10 7:56 ` Miguel Ojeda
2023-08-10 15:46 ` Greg KH
2023-08-10 20:32 ` Miguel Ojeda
2023-08-09 23:22 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703113708.1758734-1-aliceryhl@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).