From: Laura Nao <laura.nao@collabora.com>
To: skhan@linuxfoundation.org
Cc: a.hindborg@samsung.com, alex.gaynor@gmail.com,
aliceryhl@google.com, benno.lossin@proton.me,
bjorn3_gh@protonmail.com, boqun.feng@gmail.com, gary@garyguo.net,
kernel@collabora.com, kernel@valentinobst.de,
laura.nao@collabora.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, ojeda@kernel.org,
rust-for-linux@vger.kernel.org, sergio.collado@gmail.com,
shuah@kernel.org, usama.anjum@collabora.com, wedsonaf@gmail.com
Subject: Re: [PATCH v3] kselftest: Add basic test for probing the rust sample modules
Date: Mon, 26 Feb 2024 11:21:02 +0100 [thread overview]
Message-ID: <20240226102102.292374-1-laura.nao@collabora.com> (raw)
In-Reply-To: <8fe544e1-ac1c-4edf-81e9-fc0992b6bbc4@linuxfoundation.org>
Hi Shuah,
On 2/23/24 23:02, Shuah Khan wrote:
> On 2/23/24 14:48, Shuah Khan wrote:
>> On 2/22/24 09:29, Laura Nao wrote:
>>> Add new basic kselftest that checks if the available rust sample modules
>>> can be added and removed correctly.
>>>
>>> Signed-off-by: Laura Nao <laura.nao@collabora.com>
>>> Reviewed-by: Sergio Gonzalez Collado <sergio.collado@gmail.com>
>>> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>>> ---
>>> Changes in v3:
>>> - Removed useless KSFT_PASS, KSFT_FAIL, KSFT_SKIP constants
>>> - Used ktap_finished to print the results summary and handle the
>>> return code
>>> Changes in v2:
>>> - Added missing SPDX line
>>> - Edited test_probe_samples.sh script to use the common KTAP helpers
>>> file
>>> ---
>>> MAINTAINERS | 1 +
>>> tools/testing/selftests/Makefile | 1 +
>>> tools/testing/selftests/rust/Makefile | 4 +++
>>> .../selftests/rust/test_probe_samples.sh | 34 +++++++++++++++++++
>>> 4 files changed, 40 insertions(+)
>>> create mode 100644 tools/testing/selftests/rust/Makefile
>>> create mode 100755 tools/testing/selftests/rust/test_probe_samples.sh
>>>
>>
>> Looks good to me. Don't you need a config file for this test?
>> Refer to config files for existing tests as a reference.
>>
Right, in order for the tests to not be skipped support for rust and its
sample modules need to be enabled.
I added the config file in v4: https://lore.kernel.org/linux-kselftest/20240226101646.291337-1-laura.nao@collabora.com/T/#u
> make kselftest TARGETS=rust
> or
> make run_tests
>
> On Linux 6.8-rc5 give the following? Doesn't look right.
>
> TAP version 13
> 1..1
> # timeout set to 45
> # selftests: rust: test_probe_samples.sh
> # ./test_probe_samples.sh: line 12:
> /linux/linux_6.8/tools/testing/selftests/rust/../kselftest/ktap_helpers.sh: No such file or directory
> # ./test_probe_samples.sh: line 16: ktap_print_header: command not found
> # ./test_probe_samples.sh: line 18: ktap_set_plan: command not found
> # ./test_probe_samples.sh: line 22: ktap_test_skip: command not found
> # ./test_probe_samples.sh: line 22: ktap_test_skip: command not found
> # ./test_probe_samples.sh: line 34: ktap_finished: command not found
> not ok 1 selftests: rust: test_probe_samples.sh # exit=127
>
This patch requires
https://lore.kernel.org/all/20240102141528.169947-1-laura.nao@collabora.com/T/#u
and
https://lore.kernel.org/all/20240131-ktap-sh-helpers-extend-v1-0-98ffb468712c@collabora.com/
, which are both scheduled for 6.9-rc1. Sorry I didn't mention it above!
Thanks,
Laura
prev parent reply other threads:[~2024-02-26 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 16:29 [PATCH v3] kselftest: Add basic test for probing the rust sample modules Laura Nao
2024-02-23 21:48 ` Shuah Khan
2024-02-23 22:02 ` Shuah Khan
2024-02-26 10:21 ` Laura Nao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226102102.292374-1-laura.nao@collabora.com \
--to=laura.nao@collabora.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=kernel@collabora.com \
--cc=kernel@valentinobst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sergio.collado@gmail.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=usama.anjum@collabora.com \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).