rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: FUJITA Tomonori <fujita.tomonori@gmail.com>
To: benno.lossin@proton.me
Cc: fujita.tomonori@gmail.com, rust-for-linux@vger.kernel.org,
	miguel.ojeda.sandonis@gmail.com
Subject: Re: [PATCH v1] rust: add 'firmware' field support to module! macro
Date: Wed, 01 May 2024 21:37:35 +0900 (JST)	[thread overview]
Message-ID: <20240501.213735.249541417796837964.fujita.tomonori@gmail.com> (raw)
In-Reply-To: <d6e2ea94-17a7-46c6-918e-e02ce3a0922e@proton.me>

Hi,

On Wed, 01 May 2024 09:06:18 +0000
Benno Lossin <benno.lossin@proton.me> wrote:

>>  /// # Supported argument types
>>  ///   - `type`: type which implements the [`Module`] trait (required).
>>  ///   - `name`: byte array of the name of the kernel module (required).
>> @@ -74,6 +104,7 @@
>>  ///   - `description`: byte array of the description of the kernel module.
>>  ///   - `license`: byte array of the license of the kernel module (required).
>>  ///   - `alias`: byte array of alias name of the kernel module.
>> +///   - `firmware`: array of the file names of firmware required by the kernel module.
> 
> There is a patch [1] that updates this list. It will have a v2, with
> this list specifying the types that can be put there due to this [2]
> comment.
> 
> We should have the same kind of item for the `firmware` field here. I
> would suggest:
> 
>      ///   - `firmware`: array of ASCII string literals of the firmware files of the kernel module.
> 
> [1]: https://lore.kernel.org/rust-for-linux/20240419215015.157258-3-aswinunni01@gmail.com/
> [2]: https://lore.kernel.org/rust-for-linux/CANiq72=g4f60n8x=-fCxqQ4QzD2eOrEb=vEXgoNidY-N4omN1A@mail.gmail.com/

Thanks a lot!

I updated the comment as you suggested. I'll send v2 with your
Reviewed-by added shortly.

      reply	other threads:[~2024-05-01 12:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-26  9:56 [PATCH v1] rust: add 'firmware' field support to module! macro FUJITA Tomonori
2024-05-01  9:06 ` Benno Lossin
2024-05-01 12:37   ` FUJITA Tomonori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240501.213735.249541417796837964.fujita.tomonori@gmail.com \
    --to=fujita.tomonori@gmail.com \
    --cc=benno.lossin@proton.me \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).