From: Alice Ryhl <alice@ryhl.io>
To: Danilo Krummrich <dakr@redhat.com>, Alice Ryhl <aliceryhl@google.com>
Cc: a.hindborg@samsung.com, alex.gaynor@gmail.com,
benno.lossin@proton.me, bjorn3_gh@protonmail.com,
boqun.feng@gmail.com, gary@garyguo.net,
linux-kernel@vger.kernel.org, ojeda@kernel.org,
rust-for-linux@vger.kernel.org, wedsonaf@gmail.com
Subject: Re: [PATCH v3] rust: str: add {make,to}_{upper,lower}case() to CString
Date: Fri, 16 Feb 2024 20:25:39 +0100 [thread overview]
Message-ID: <75a5a4cc-af27-415a-87b8-9e231574a519@ryhl.io> (raw)
In-Reply-To: <18a49662-3640-49c1-9587-db5cc9d62fbc@redhat.com>
On 2/16/24 18:11, Danilo Krummrich wrote:
> On 2/16/24 17:53, Alice Ryhl wrote:
>>> + /// Returns a copy of this [`CString`] where each character is
>>> mapped to its
>>> + /// ASCII upper case equivalent.
>>> + ///
>>> + /// ASCII letters 'a' to 'z' are mapped to 'A' to 'Z',
>>> + /// but non-ASCII letters are unchanged.
>>> + ///
>>> + /// To uppercase the value in-place, use [`make_ascii_uppercase`].
>>> + ///
>>> + /// [`make_ascii_uppercase`]: str::make_ascii_uppercase
>>> + pub fn to_ascii_uppercase(&self) -> Result<CString, AllocError> {
>>> + let mut s = (*self).to_cstring()?;
>>> +
>>> + s.make_ascii_uppercase();
>>> +
>>> + return Ok(s);
>>> + }
>>
>> Please move these to `CStr` as well.
>
> That would result into two copies if I actually want a CString, wouldn't
> it?
>
> Also, what would be the use case? And even if someone wants to have a CStr
> again, couldn't we just deref the resulting CString?
To clarify, I want you to move it to the `impl CStr` block. That changes
the type of the `self` argument. I don't want you to change the return
type - that should still be `CString`.
Currently, if I have a `&CStr` and I want an uppercase `CString`, I
can't do that with this method.
Alice
prev parent reply other threads:[~2024-02-16 19:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 17:24 [PATCH v3] rust: str: add {make,to}_{upper,lower}case() to CString Danilo Krummrich
2024-02-14 19:27 ` Boqun Feng
2024-02-14 19:59 ` Alice Ryhl
2024-02-15 1:18 ` Boqun Feng
2024-02-15 9:38 ` Alice Ryhl
2024-02-15 16:51 ` Boqun Feng
2024-02-16 9:09 ` Alice Ryhl
2024-02-16 16:53 ` Alice Ryhl
2024-02-16 17:11 ` Danilo Krummrich
2024-02-16 19:25 ` Alice Ryhl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75a5a4cc-af27-415a-87b8-9e231574a519@ryhl.io \
--to=alice@ryhl.io \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@redhat.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).