From: Alice Ryhl <alice@ryhl.io>
To: Benno Lossin <benno.lossin@proton.me>
Cc: rust-for-linux@vger.kernel.org, "Miguel Ojeda" <ojeda@kernel.org>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
linux-kernel@vger.kernel.org, patches@lists.linux.dev
Subject: Re: [PATCH] rust: make `UnsafeCell` the outer type in `Opaque`
Date: Wed, 14 Jun 2023 16:37:42 +0200 [thread overview]
Message-ID: <77089cc6-233c-9329-a994-95ae6d3d07e3@ryhl.io> (raw)
In-Reply-To: <zirWeKUZRqFhiN23v0pXHMmvuceI7EZyVvNUiREGf-UNbIbXLrHjbC8diUNg9v802jbX1978ezQLDCl--1M5S6K8l7CVWs8JGB-znEEMRNE=@proton.me>
On 6/14/23 16:27, Benno Lossin wrote:>> @@ -258,7 +258,7 @@ pub fn
ffi_init(init_func: impl FnOnce(*mut T)) -> impl PinInit<Self> {
>>
>> /// Returns a raw pointer to the opaque data.
>> pub fn get(&self) -> *mut T {
>> - UnsafeCell::raw_get(self.0.as_ptr())
>> + UnsafeCell::get(&self.0).cast::<T>()
>
> Is there a reason you don't do `self.0.get().cast::<T>()`?
>
Not really. I just modified what was already there.
next prev parent reply other threads:[~2023-06-14 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 11:53 [PATCH] rust: make `UnsafeCell` the outer type in `Opaque` Alice Ryhl
2023-06-14 14:27 ` Benno Lossin
2023-06-14 14:37 ` Alice Ryhl [this message]
2023-06-14 15:30 ` Martin Rodriguez Reboredo
2023-06-14 18:42 ` Gary Guo
2023-06-14 19:04 ` Benno Lossin
2023-08-09 23:21 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77089cc6-233c-9329-a994-95ae6d3d07e3@ryhl.io \
--to=alice@ryhl.io \
--cc=alex.gaynor@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=patches@lists.linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).