From: Andreas Hindborg <nmi@metaspace.dk>
To: "Maíra Canal" <mcanal@igalia.com>
Cc: "Asahi Lina" <lina@asahilina.net>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Alice Ryhl" <aliceryhl@google.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Matt Gilbride" <mattgilbride@google.com>,
"Lyude Paul" <lyude@redhat.com>,
"Danilo Krummrich" <dakr@redhat.com>,
rust-for-linux@vger.kernel.org, kernel-dev@igalia.com,
"Léo Lanteri Thauvin" <leseulartichaut@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@google.com>
Subject: Re: [PATCH] rust: Add `container_of` and `offset_of` macros
Date: Mon, 19 Feb 2024 10:51:47 +0100 [thread overview]
Message-ID: <87plwsg3yx.fsf@metaspace.dk> (raw)
In-Reply-To: <20240217153315.56128-1-mcanal@igalia.com>
Hi Maira,
Maíra Canal <mcanal@igalia.com> writes:
> From: Asahi Lina <lina@asahilina.net>
>
> Add Rust counterparts to these C macros. `container_of` is useful for C
> struct subtyping, to recover the original pointer to the container
> structure. `offset_of` is useful for struct-relative addressing.
>
> Co-authored-by: Miguel Ojeda <ojeda@kernel.org>
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> Co-authored:by: Léo Lanteri Thauvin <leseulartichaut@gmail.com>
> Signed-off-by: Léo Lanteri Thauvin <leseulartichaut@gmail.com>
> Co-authored-by: Wedson Almeida Filho <wedsonaf@google.com>
> Signed-off-by: Wedson Almeida Filho <wedsonaf@google.com>
> Signed-off-by: Asahi Lina <lina@asahilina.net>
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
>
> Hi,
>
> `container_of` is a essential macro to build any sort of driver in the
> Linux Kernel. Therefore, we need a good and reliable implementation of
> this macro for the Rust abstractions.
>
> Although I checked the version sent by Matt [1], I don't really like the
> fact that such an essential part of the foundation of any driver would
> be an unsafe macro. Therefore, I propose this alternative to Matt's
> implementation, which is Lina's implementation that it is actually safe.
>
> `container_of` is a dependency for the rustgem driver and this is part
> of my current efforts to upstream the driver.
>
`offset_of!()` is available as `core::mem::offset_of!()` under unstable
feature gate, which is currently enabled and used in the workqueue
abstractions. So at least that macro is not required.
Best regards,
Andreas
prev parent reply other threads:[~2024-02-19 10:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240217153356eucas1p17c926b49da33a438d286ebb5c1a918c9@eucas1p1.samsung.com>
2024-02-17 15:32 ` [PATCH] rust: Add `container_of` and `offset_of` macros Maíra Canal
2024-02-18 17:10 ` Martin Rodriguez Reboredo
2024-02-19 9:49 ` Alice Ryhl
2024-02-19 21:57 ` Maíra Canal
2024-02-19 22:04 ` Alice Ryhl
2024-02-20 15:54 ` Miguel Ojeda
2024-02-21 11:27 ` Maíra Canal
2024-02-25 20:30 ` Miguel Ojeda
2024-02-19 9:51 ` Andreas Hindborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plwsg3yx.fsf@metaspace.dk \
--to=nmi@metaspace.dk \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@redhat.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-dev@igalia.com \
--cc=leseulartichaut@gmail.com \
--cc=lina@asahilina.net \
--cc=lyude@redhat.com \
--cc=mattgilbride@google.com \
--cc=mcanal@igalia.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
--cc=wedsonaf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).