From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Wedson Almeida Filho <wedsonaf@google.com>
Cc: rust-for-linux@vger.kernel.org
Subject: Re: File operations
Date: Thu, 10 Dec 2020 00:18:02 +0100 [thread overview]
Message-ID: <CANiq72maQNCGT=ff9BrsqY81mXjzeYpKxDy9rZL36cmgfCZt-w@mail.gmail.com> (raw)
In-Reply-To: <CAMKQLNLp+XfVcQf_+8OHJO=faTkwfdiFYR2s72LoAryHxFBJFA@mail.gmail.com>
On Wed, Dec 9, 2020 at 10:49 PM Wedson Almeida Filho
<wedsonaf@google.com> wrote:
>
> How do you all feel about this? I think it is an improvement but would
> like to hear what you think before spending more time on this.
Not sure... On one hand the first snippet looks very cumbersome; on
the other hand, introducing a macro for just a line may not be over
the threshold of "is this sugar worth enough?".
The macro makes the fileops functions look more normal, so I think it
would be fine, but don't spend too much time on that if you feel it
gets too convoluted: we will likely know how much macro magic people
enjoy if we end up being successful in introducing Rust in the kernel
:-)
Nevertheless, however you do it, having actual non-trivial drivers
implemented is a *very* nice thing!
Cheers,
Miguel
next prev parent reply other threads:[~2020-12-09 23:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 21:47 File operations Wedson Almeida Filho
2020-12-09 23:18 ` Miguel Ojeda [this message]
2020-12-13 0:01 ` Wedson Almeida Filho
2020-12-13 0:50 ` Miguel Ojeda
2020-12-13 2:12 ` Wedson Almeida Filho
2020-12-13 3:33 ` Miguel Ojeda
2020-12-14 2:02 ` Wedson Almeida Filho
2020-12-18 3:58 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72maQNCGT=ff9BrsqY81mXjzeYpKxDy9rZL36cmgfCZt-w@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).