From: Boqun Feng <boqun.feng@gmail.com>
To: Alice Ryhl <aliceryhl@google.com>
Cc: rust-for-linux@vger.kernel.org, "Tejun Heo" <tj@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Lai Jiangshan" <jiangshanlai@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
linux-kernel@vger.kernel.org, patches@lists.linux.dev
Subject: Re: [PATCH v4 0/7] rust: workqueue: add bindings for the workqueue
Date: Mon, 11 Sep 2023 22:14:41 -0700 [thread overview]
Message-ID: <ZP_zwc6UuirLSstf@Boquns-Mac-mini.home> (raw)
In-Reply-To: <20230828104807.1581592-1-aliceryhl@google.com>
On Mon, Aug 28, 2023 at 10:48:00AM +0000, Alice Ryhl wrote:
> This patchset contains bindings for the kernel workqueue.
>
> One of the primary goals behind the design used in this patch is that we
> must support embedding the `work_struct` as a field in user-provided
> types, because this allows you to submit things to the workqueue without
> having to allocate, making the submission infallible. If we didn't have
> to support this, then the patch would be much simpler. One of the main
> things that make it complicated is that we must ensure that the function
> pointer in the `work_struct` is compatible with the struct it is
> contained within.
>
> The original version of the workqueue bindings was written by Wedson,
> but I have rewritten much of it so that it uses the pin-init
> infrastructure and can be used with containers other than `Arc`.
>
> This patchset depends on the patch [1] that changes `Opaque` to be
> `!Unpin` for correctness. The patchset is based on the rust-6.6 tag,
> since that tag includes that patch.
>
> Changes v3 -> v4:
>
> * Use `offset_of!` macro from standard library, and drop patch with
> custom implementation.
> * Add name parameter to `work_struct` constructor, and drop patch with
> __INIT_WORK_WITH_KEY.
> * Various improvements to documentation and comments.
>
> More detailed changelogs can be found on the individual patches.
>
For the whole series:
Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Regards,
Boqun
> Previous versions:
> v1: https://lore.kernel.org/all/20230517203119.3160435-1-aliceryhl@google.com/
> v2: https://lore.kernel.org/all/20230601134946.3887870-1-aliceryhl@google.com/
> v3: https://lore.kernel.org/all/20230711093303.1433770-1-aliceryhl@google.com/
>
> [1]: https://lore.kernel.org/all/20230630150216.109789-1-benno.lossin@proton.me/
>
> Alice Ryhl (5):
> rust: workqueue: add low-level workqueue bindings
> rust: workqueue: add helper for defining work_struct fields
> rust: workqueue: implement `WorkItemPointer` for pointer types
> rust: workqueue: add `try_spawn` helper method
> rust: workqueue: add examples
>
> Wedson Almeida Filho (2):
> rust: sync: add `Arc::{from_raw, into_raw}`
> rust: workqueue: define built-in queues
>
> rust/bindings/bindings_helper.h | 1 +
> rust/helpers.c | 13 +
> rust/kernel/lib.rs | 3 +
> rust/kernel/sync/arc.rs | 46 ++-
> rust/kernel/workqueue.rs | 679 ++++++++++++++++++++++++++++++++
> scripts/Makefile.build | 2 +-
> 6 files changed, 741 insertions(+), 3 deletions(-)
> create mode 100644 rust/kernel/workqueue.rs
>
> base-commit: 4af84c6a85c63bec24611e46bb3de2c0a6602a51
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
next prev parent reply other threads:[~2023-09-12 5:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 10:48 [PATCH v4 0/7] rust: workqueue: add bindings for the workqueue Alice Ryhl
2023-08-28 10:48 ` [PATCH v4 1/7] rust: sync: add `Arc::{from_raw, into_raw}` Alice Ryhl
2023-08-28 10:48 ` [PATCH v4 2/7] rust: workqueue: add low-level workqueue bindings Alice Ryhl
2023-08-28 10:48 ` [PATCH v4 3/7] rust: workqueue: define built-in queues Alice Ryhl
2023-08-28 10:48 ` [PATCH v4 4/7] rust: workqueue: add helper for defining work_struct fields Alice Ryhl
[not found] ` <CGME20230828112151eucas1p2371f4cf778e6265e8ac5baf8ea91be4d@eucas1p2.samsung.com>
2023-08-28 11:21 ` Andreas Hindborg
2023-09-04 0:29 ` Martin Rodriguez Reboredo
2023-09-05 10:07 ` Benno Lossin
2023-09-06 9:56 ` Alice Ryhl
2023-09-26 10:01 ` Alice Ryhl
2023-09-23 2:56 ` Gary Guo
2023-08-28 10:48 ` [PATCH v4 5/7] rust: workqueue: implement `WorkItemPointer` for pointer types Alice Ryhl
2023-08-28 10:48 ` [PATCH v4 6/7] rust: workqueue: add `try_spawn` helper method Alice Ryhl
2023-08-28 10:48 ` [PATCH v4 7/7] rust: workqueue: add examples Alice Ryhl
2023-10-03 20:13 ` Konstantin Shelekhin
2023-10-03 22:29 ` Alice Ryhl
2023-10-04 11:06 ` Konstantin Shelekhin
2023-10-04 14:38 ` Boqun Feng
2023-10-04 14:56 ` Konstantin Shelekhin
2023-10-04 15:49 ` Andreas Hindborg (Samsung)
2023-10-05 6:32 ` Trevor Gross
2023-09-12 5:14 ` Boqun Feng [this message]
2023-09-25 19:49 ` [PATCH v4 0/7] rust: workqueue: add bindings for the workqueue Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZP_zwc6UuirLSstf@Boquns-Mac-mini.home \
--to=boqun.feng@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=gary@garyguo.net \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=patches@lists.linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=tj@kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).