From: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>
Subject: Re: [PATCH v2] rust: alloc: Add realloc and alloc_zeroed to the GlobalAlloc impl
Date: Mon, 26 Jun 2023 10:11:40 -0300 [thread overview]
Message-ID: <b6a3bb29-ea6f-cdec-3f0f-4db51f385ec8@gmail.com> (raw)
In-Reply-To: <CANiq72kVUv4djvhLxz5tRYn-U2kXZMs0N1M=CZxdznnN0jY47Q@mail.gmail.com>
On 6/26/23 06:40, Miguel Ojeda wrote:
> On Mon, Jun 26, 2023 at 5:34 AM Martin Rodriguez Reboredo
> <yakoyoku@gmail.com> wrote:
>>
>> I think that this should go above Link and Signed-off-bys, although I'm
>> not sure if maintainers do it when is merged.
>
> Both styles are used, it is fine either way. Personally, I pick one or
> the other depending on the kind of comment.
>
> Having said that, there seems to be a missing `From:`, but I can fix
> that on my side if Björn is the intended author.
>
>> Newbie question, aren't tabs in the commit message verboten?
>
> I am not aware of such a rule, and there are commits in the kernel
> with tabs, e.g. commit 9828ed3f695a ("module: error out early on
> concurrent load of the same module file").
>
> In any case, that text doesn't go into the commit message, because it
> is after the `---` line.
>
> Cheers,
> Miguel
Alrighty, both make sense to me, thanks for the explanations!
-> Martin
next prev parent reply other threads:[~2023-06-26 13:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-25 23:25 [PATCH v2] rust: alloc: Add realloc and alloc_zeroed to the GlobalAlloc impl Boqun Feng
2023-06-26 3:34 ` Martin Rodriguez Reboredo
2023-06-26 9:40 ` Miguel Ojeda
2023-06-26 13:11 ` Martin Rodriguez Reboredo [this message]
2023-06-28 10:07 ` Benno Lossin
2023-06-28 16:43 ` Gary Guo
2023-07-29 14:01 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6a3bb29-ea6f-cdec-3f0f-4db51f385ec8@gmail.com \
--to=yakoyoku@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).