Re: [PATCH v2] scripts: read cfgs from Makefile for rust-analyzer

[Benno Lossin <benno.lossin@proton.me>]

On 15.07.23 05:33, Martin Rodriguez Reboredo wrote:
> On 7/14/23 12:55, Benno Lossin wrote:
>>> Both `core` and `alloc` had their `cfgs` missing in `rust-project.json`,
>>> to remedy this `generate_rust_analyzer.py` scans the Makefile from
>>> inside the `rust` directory for them to be added to a dictionary that
>>> each key corresponds to a crate and each value, to an array of `cfgs`.
>>>
>>> Signed-off-by: Martin Rodriguez Reboredo yakoyoku@gmail.com
>>
>> When I try this patch *all* configuration options are input into the `cfg`
>> field of the `core` crate (others are also affected):
>> ```json
>>               "cfg": [
>>                   "CONFIG_RING_BUFFER",
>>                   "CONFIG_RING_BUFFER=\"y\"",
>>                   "CONFIG_HAVE_ARCH_SECCOMP_FILTER",
>>                   "CONFIG_HAVE_ARCH_SECCOMP_FILTER=\"y\"",
>>                   "CONFIG_KERNEL_GZIP",
>>                   "CONFIG_KERNEL_GZIP=\"y\"",
>>                   "CONFIG_CC_HAS_SANCOV_TRACE_PC",
>>                   "CONFIG_CC_HAS_SANCOV_TRACE_PC=\"y\"",
>>                   "CONFIG_ARCH_WANT_OPTIMIZE_VMEMMAP",
>> ```
>> The snippet would continue on for about 1000 lines.
>> I think this is wrong and not intended.
>>
>> --
>> Cheers,
>> Benno
>>
> 
> Wait, can you tell me which branch are you on? As it works on
> `rust-dev` and `rust-next` with `make rust-analyzer`. Also, do you
> have any other details?

I tried it on both `rust-dev` and on `rust-next` and on both I have
this problem. Here is what I executed:

```sh
git checkout $branch
make clean
make mrproper
make menuconfig
make LLVM=1 rust-analyzer
```

In the `make menuconfig` step I disabled `DEBUG_INFO_BTF` and enabled
`RUST`.

If you want, I can upload the `rust-project.json` file to GH, since
it is 55k lines long.

-- 
Cheers,
Benno