From: Russell Coker <russell@coker.com.au>
To: Dominick Grift <dominick.grift@defensec.nl>
Cc: selinux-refpolicy@vger.kernel.org
Subject: Re: [PATCH] misc network patches with Dominick's changes
Date: Thu, 28 Jan 2021 03:35:33 +1100 [thread overview]
Message-ID: <3290098.uLzDavUzRi@liv> (raw)
In-Reply-To: <ypjl8s8ejyoj.fsf@defensec.nl>
On Thursday, 28 January 2021 12:29:16 AM AEDT Dominick Grift wrote:
> > Index: refpolicy-2.20210126/policy/modules/system/sysnetwork.fc
> > ===================================================================
> > --- refpolicy-2.20210126.orig/policy/modules/system/sysnetwork.fc
> > +++ refpolicy-2.20210126/policy/modules/system/sysnetwork.fc
> > @@ -27,6 +27,7 @@ ifdef(`distro_debian',`
> >
> > /etc/dhcp3?/dhclient.* gen_context(system_u:object_r:dhcp_etc_t,s0)
> >
> > /etc/systemd/network(/.*)? gen_context(system_u:object_r:net_conf_t,s0)
> >
> > +/etc/tor/torsocks.conf -- gen_context(system_u:object_r:net_conf_t,s0)
>
> minor but bet to escape the period: /etc/tor/torsocks\.conf
OK fixed that.
> not sure why you associate this with net_conf_t. I probably would have
> labeled all of /etc/tor tor_conf_t (for confined tor administration etc)
Because other programs that want to use tor look at it for information on how
to connect to tor via socks.
> > Index: refpolicy-2.20210126/policy/modules/roles/unprivuser.te
> > ===================================================================
> > --- refpolicy-2.20210126.orig/policy/modules/roles/unprivuser.te
> > +++ refpolicy-2.20210126/policy/modules/roles/unprivuser.te
> > @@ -25,6 +25,10 @@ optional_policy(`
> >
> > ')
> >
> > optional_policy(`
> >
> > + netutils_domtrans_ping(user_t)
> > +')
>
> this is already allowed conditionally as said before. you should be able
> to remove this.
OK, removed that.
I'll send another patch now.
--
My Main Blog http://etbe.coker.com.au/
My Documents Blog http://doc.coker.com.au/
prev parent reply other threads:[~2021-01-27 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 7:12 [PATCH] misc network patches with Dominick's changes Russell Coker
2021-01-27 13:29 ` Dominick Grift
2021-01-27 16:35 ` Russell Coker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3290098.uLzDavUzRi@liv \
--to=russell@coker.com.au \
--cc=dominick.grift@defensec.nl \
--cc=selinux-refpolicy@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).