From: Chris PeBenito <pebenito@ieee.org>
To: Alexander Miroshnichenko <alex@millerson.name>,
selinux-refpolicy@vger.kernel.org
Subject: Re: [PATCH] add lldpd policy
Date: Sat, 15 Jun 2019 15:24:03 -0400 [thread overview]
Message-ID: <3d0d13b8-3090-558e-23b6-7edaeeff3f92@ieee.org> (raw)
In-Reply-To: <20190615175859.GA2818@brutus.lan>
On 6/15/19 1:58 PM, Dominick Grift wrote:
> On Sat, Jun 15, 2019 at 12:08:16PM -0400, Chris PeBenito wrote:
>> On 6/10/19 10:20 AM, Alexander Miroshnichenko wrote:
>>> +allow lldpd_t self:process { fork signal_perms };
>>> +allow lldpd_t self:fifo_file rw_fifo_file_perms;
>>> +allow lldpd_t self:unix_stream_socket { accept listen };
>>
>> These perms should probably be create_stream_socket_perms.
>
> the other permissions are already provided with logging_send_syslog_msg() so would be reduntant
This is true. However,the syslog socket is not the only socket in use.
Since it also listens on its own stream socket, the
create_stream_socket_perms more clearly shows the intent.
--
Chris PeBenito
next prev parent reply other threads:[~2019-06-15 19:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 14:20 [PATCH] add lldpd policy Alexander Miroshnichenko
2019-06-15 16:08 ` Chris PeBenito
2019-06-15 17:58 ` Dominick Grift
2019-06-15 19:24 ` Chris PeBenito [this message]
2019-06-15 19:43 ` Dominick Grift
2019-06-17 12:23 ` Alexander Miroshnichenko
2019-06-17 12:42 ` [PATCH v2] Add " Alexander Miroshnichenko
2019-06-24 1:15 ` Chris PeBenito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d0d13b8-3090-558e-23b6-7edaeeff3f92@ieee.org \
--to=pebenito@ieee.org \
--cc=alex@millerson.name \
--cc=selinux-refpolicy@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).